gorhill / ublock-for-firefox-legacy Goto Github PK
View Code? Open in Web Editor NEWuBlock Origin for Firefox legacy-based browsers.
License: GNU General Public License v3.0
uBlock Origin for Firefox legacy-based browsers.
License: GNU General Public License v3.0
References:
uBlockOrigin/uBlock-issues#760
When these type of rules starts to appear, it's important that uBO Legacy supports them!:
https://github.com/gorhill/uBlock/commit/3c67d2b89f8ac6d680e74af3e11b916889f7/
After most recent commit
file CONTRIBUTING.md still directs visitors to
https://github.com/uBlockOrigin/uBlock-issues/issues
Kindly modify accordingly, thanks... ๐
Currently, filter syntax converter applies only to an explicitly specified limited set of filters, and also does not apply to "My filters".
There was a request that this behavior needs to be adjusted.
This issue is intended for release communication.
Currently middle click on uBlock icon does nothing.
It would be really useful if we could choose between:
Thank you.
Open URL https://mpc-hc.org/
After clicking on the "zapper" or "picker" button, I see a broken pop-up interface.
Disabling all filters does not affect the problem.
Ability to select a page elements.
Unable to select page elements. Pop-up interface is broken.
Reference:
uBlockOrigin/uBlock-issues#385
Keyconfig element is already created from the start, but there is no UI for binding keys.
As a reference you could take a look at Dorando Keyconfig or TGS.
Currently, neither $all
or $doc
seem to be supported by Firefox Legacy, as any strict blocking prompts don't show up.
Fixing $doc
would be as simple as adding 'doc': 'main_frame'
to
uBlock-for-firefox-legacy/src/js/static-net-filtering.js
Lines 1379 to 1409 in 755a8e0
$all
would possibly have to be converted into two different entries at once, one for nothing at all and one for $popup
. Arguably even a third one for $document
would have to be added, leading to complexity that makes me wonder if it's more ideal to just add native support for $all
instead.
Just about anywhere on the internet, but let's assume https://www.nrk.no/
as a very, very safe test site for this.
||nrk.no^$all
and ||nrk.no^$doc
to My Filters.https://www.nrk.no/
.The strict blocking page shows up.
There are several issues with svg icons in redesigned dashboard on Gecko 45-51:
for ( const
loop need to be replaced with for ( let
href
attribute, so svg icons are not visible at allI tried to use xlink:href
instead of href
, but that only worked for checkboxes statically defined in settings.html
and 3p-filters.html
, but not for fa-icons.js
-generated icons.
I believe we should still try to fix this by providing some workaround, primarily for TenFourFox.
@hawkeye116477, could you please take a look at this?
Easylist Cookie List seems to have been removed from this URL now:
https://easylist-downloads.adblockplus.org/easylist-cookie.txt
Therefore, the filter's contentURL needs to be updated in uBO Legacy, to the one currently used by uBO's main branch, which is this one:
https://secure.fanboy.co.nz/fanboy-cookiemonster.txt
I was mistaken about the repositories, because legacy has limited support for HTML Filtering:
example.org##script:contains(...)
not like:
example.org##^script:has-text(...)
How and where do I make a donation to Gorhill ?
[Description of the bug or feature]
I try to install uBlock0_1.16.4.28.firefox-legacy.xpi file and get the warning of "add-on could not be install because it had not been verified" on my FF browser this include uBlock0_1.33.2.firefox.signed.xpi since it say that it not compatible with FF 53.0.3
[A specific URL is MANDATORY for issue happening on a web page, even if it happens "everywhere"]
the add-on is install without any warning
get cannot be verified warning even xpinstall.signatures.required set to false
When opening the uBO Dashboard, the browser's page Refresh button (at the end of the url / location bar) gets disabled for all existing open tabs, and also for any subsequent new tabs that are opened after the uBO Dashboard. The refresh button icon changes from it's default circular arrow to an x, and it becomes unclickable.
Closing the uBO Dashboard tab does not restore the refresh button back to its working state (it remains unclickable in all tabs). However, the refresh button functionality is restored if the web browser is restarted.
This issue is not a recent development; it has been present in previous uBO legacy releases.
Occurs everywhere.
note: self-contained portable version of Waterfox Classic (no installation required) is available here:
(select 'Download Portable'โโ https://www.waterfox.net/download/#classic )
The function of the refresh buttons should continue to work as normal (even if the uBO dashboard is open).
None of the refresh buttons work (they all become unclickable).
I have XP SP3 & FF ESR & Ublock 1.17.4 which version is new yours or mine? I see your release is quite new (August 2020) but your version number lower than latest ESR compatible Ublock.
Might just as well release it with the current changes, don't you think?
Initially reported in #229 (comment).
1 - Add this blocking rule to your filters (found in 'Lunar Blocklist by Moonchild'):
||pixel.
2 - Open this page, and observe as all article images are blocked:
https://www.thecut.com/2016/08/winona-ryder-c-v-r.html
3 - Add one of the following whitelisting rules:
@@||pixel.nymag.com/imgs/$doc,image
or
@@||pixel.nymag.com/imgs/$document,image
4 - Reload the page, and observe as all article images are now shown.
5 - Now, right-click on one of the images, and select "View Image"..
The direct-linked image is now blocked!
6 - Add this whitelisting rule:
@@||pixel.nymag.com/imgs/$all
7 - Right-click on one of the images, and select "View Image" again..
The direct-linked image is now shown, while uBO's logger clearly states that it's allowed by the $doc
variable.
So, why doesn't $doc
or $document
work?
As noted by JustOff, in his post below the one that I linked to above, the issue is not related to the recently implemented $all
and $doc
syntax support.
References:
uBlockOrigin/uBlock-issues#701
https://github.com/gorhill/uBlock/commit/68ae847ba385c09c5efa511d18a18a4753af47be/
Note:
$empty
doesn't show up as invalid in uBO Legacy's logger, so I assume that it is supported already?:
https://github.com/gorhill/uBlock/commit/3e5c9e00ab3603ae0c02e08b007b084404bbb71d/
apparently there is support Firefox 52.9 esr
#274 (comment) the same is possible with english
Toolbar button is too wide, has too much padding on both sides, and the icon is not symmetrically positioned.
Reported at https://forum.palemoon.org/viewtopic.php?t=25076&p=198154.
See also: uBlock-LLC/uBlock#1315, uBlock-LLC/uBlock#1321, uBlock-LLC/uBlock#1449, gorhill/uBlock#264.
about:blank
and everywhere
When watching any random videos, occasionally a white screen loads up with a "Skip Ad" button instead of a video.
Looks like this issue was fixed in the master branch a few days ago, where json-prune scriptlet now comes with the ability to prune all fetch calls.
Videos display normally with no interruption.
Got flashbanged by an unskippable white screen in the middle of watching videos.
uBlock Origin reports negative number of used filters on chrome://ublock0/content/dashboard.html
.
uBlock Origin โค 1.16.4.24 is not affected.
https://raw.githubusercontent.com/LanikSJ/ubo-filters/master/filters/admiral-domains.txt
https://s3.amazonaws.com/lists.disconnect.me/simple_malvertising.txt
https://raw.githubusercontent.com/LanikSJ/ubo-filters/master/filters/admiral-domains.txt
Reference:
https://github.com/DandelionSprout/adfilt/issues/7/#issuecomment-503587322
Apparently this is because of "deprecated pseudo operators":
gorhill/uBlock#3683
Note:
I don't think this can be remedied by the convertion script, because some of the deprecated syntaxes are still commonly used (and works) with certain types of rules.
Since resources.txt
hosted on uAssets
has become obsolete, it should be incorporated into the local repo. This will allow keeping the scriptlets in sync with the upstream scriptlets.js.
no-setInterval-if.js
)no-setTimeout-if.js
)requestAnimationFrame-if.js
)resources.txt
when installing a new versionapplies to uBlock0_1.16.4.27b2.firefox-legacy beta test from #278 (comment)
this is just my suggestion - active places choice ( applies to all โ๏ธ๐ฒ in Settings/Filter lists)
๐ฆ is ok
๐ฉ should be
๐ฅ now is
All has-text cosmetic filters are logged as invalid. The logger will output "Cosmetic filtering โ invalid filter:" messages for all cosmetic filters containing "has-text". I back tested and found that the issue began with version 1.16.4.24 and continues to the latest version 1.16.4.26. 1.16.4.23 works fine and does not generate the logger errors. At first blush, it appears from the logger messages that the URL and hashtags are being removed from the filter, but in messing around with some purposely invalid filters in 1.16.4.23, I think this may be normal extension behavior.
I'll give you 2, but this issue occurs with any has-text cosmetic filter. You don't need to visit any site to generate the errors. Just create some filters and watch the logger.
filter: yelp.com##li:has-text(Ad)
logger: Cosmetic filtering โ invalid filter: li:has-text(Ad)
filter: digg.com##.digg-story:has-text(SPONSORED)
logger: Cosmetic filtering โ invalid filter: .digg-story:has-text(SPONSORED)
The behavior of 1.16.4.23, where "has-text" filters do not generate errors in the log.
All "has-text" filters generate errors in the log.
Thanks for keeping uBlock Origin updated for Palemoon. I haven't been able to so far, but if I can figure out a fix for this, I will provide a patch.
This happened maybe a few times couple of weeks ago and haven't reoccur since until today. Now youtube will show ads and leave a dkv
cookie. Subsequent videos then will not have ads. But if I clear that cookie, then a new static ads will appear. This is on a windows 10 and firefox 52esr.
Edit: Uh oh. I just got one in chrome too. Though it didn't reappear after clearing cookies. Can anyone double check? paging @gorhill
Edit2: Hmm. If I open it in private/incognito mode, it doesn't show ads so far. I have my regular tab logged into youtube.
Despite the link to remote assets.json
has already been updated, it is stuck in assetSourceRegistry
and points to an already non-existent place. This prevents the list of assets from being updated.
This is a known issue that needs to be addressed.
As a workaround to clear the cache, you must manually save and then restore the settings using chrome://ublock0/content/dashboard.html#settings.html
.
On uBO web-ext I can do for example belvederehotel.pl##+js(abort-on-property-read, pf_queen.push)
, so I can omit .js
from scriptlet name, but seems that doesn't work with uBO Legacy.
Reference (fixed in main branch):
uBlockOrigin/uBlock-issues#627
It would be great if uBO Legacy will support procedural cosmetic operator remove()
.
gorhill/uBlock@72bb700.
Can you make my dream come true?
I'd like to have option to search throught all enabled filters.
For example: "google" > list of filters with text "google".
In current version i have to search through each list separately.
While I haven't tested it in Pale Moon (nor SeaMonkey) myself, I think uBO added the new ":nth-ancestor" feature to the regular uBO versions sometime in the past year, and I'm already liking it enough that I'm predicting it'll become a major feature in uBO-specific lists within the next year or two.
So I presume that adding support for it would be advantageous for you guys.
Reference:
uBlockOrigin/uBlock-issues#500
Once extension/add-on was removed from SeaMonkey, ads continue to be blocked.
[A specific URL is MANDATORY for issue happening on a web page, even if it happens "everywhere"]
Ads should no longer be blocked after removal of extension.
Ads are still being blocked.
It appears that when the add-on/extension was removed, it did not remove all remnants of the software. There were four 'ublock0' entries in the config file after removal of add-on. Those were removed by resetting them. Upon another relaunch of SeaMonkey, ads remain blocked.
References:
gorhill/uBlock@c77f697
Note:
Obvious problem in "Online Malicious URL Blocklist" that has gone to twice as many rules in the last few days than before.
Reference:
gorhill/uBlock#127
it is missing in many filters .js
therefore they do not work
"ubo legacy" still requires .js
is it possible to increase the compatibility with "ubo"
my problem example MajkiIT/polish-ads-filter#13818 (comment)
did not work page#@#+js(set-constant, Object.prototype.rekids, undefined)
it works page#@#+js(set-constant.js, Object.prototype.rekids, undefined)
Element Picker and Element Zapper don't work anymore in new 1.16.4.22 legacy version.
https://github.com/gorhill/uBlock-for-firefox-legacy/issues
Element picker is launched
Nothing happen (no error in browser console)
This used to work just fine, but apparently uBO Legacy has now been affected by the same regression bug as the main branch was, back in 2019:
uBlockOrigin/uBlock-issues#464
CSS selector-based cosmetic filters test:
https://gorhill.github.io/uBlock/tests/css-selector-based-cosmetic-filters.html
Culprit:
#279
Fix (main branch):
https://github.com/gorhill/uBlock/commit/f10b1003793a54d5d04c819e94cad02c78e10a82/
Encountered blocking issues as described in this link and subsequently installed build 1.16.4.20 as recommended. However the build causes my system to overheat. Have removed it now and reinstalled 1.26.2 which runs without a problem. The Zapper fails to work on later builds i.e. 1.27.2 and beyond.
https://www.theguardian.com/international
Build should not cause the system to overheat.
Machine runs too hot.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.