GithubHelp home page GithubHelp logo

apikeyauthentication's People

Contributors

gowthamece avatar

Stargazers

Nelson Nina avatar Erwin Hendriks avatar Alain Forteza avatar Gérôme GUILLEMIN avatar  avatar Mumtaz Malik avatar Nguyen Huu Anh Tuan avatar Sutanto Gasali avatar Chuen Lee avatar Rafael Miranda avatar Julien Nicole avatar Janek Vačkář avatar  avatar  avatar Nelson Psenjen avatar Thammac avatar Muhammad Kashif Sattar avatar Jaeyong Park avatar Abhi Joshi avatar Marc Durham avatar Nasir khalil avatar

Watchers

James Cloos avatar  avatar

apikeyauthentication's Issues

ApiKey comparison has timing attack vulnerability

The current implementation of apiKey comparison has timing attack vulnerability.

The file ApiKeyMiddleware.cs current implementation is as follows:

if (!apiKey.Equals(extractedApiKey))
{
  context.Response.StatusCode = 401;
  await context.Response.WriteAsync("Unauthorized client");
  return;
}

Should be something like:

var equals = CryptographicOperations.FixedTimeEquals(
  System.Text.Encoding.UTF8.GetBytes( apiKey ),
  System.Text.Encoding.UTF8.GetBytes( extractedApiKey ) );

if( !equals )
{
  context.Response.StatusCode = 401;
  await context.Response.WriteAsync( "Unauthorized client" );
  return;
}

See:
https://en.wikipedia.org/wiki/Timing_attack
https://vcsjones.dev/fixed-time-equals-dotnet-core
https://michaelhowardsecure.blog/2019/02/22/the-dangers-of-string-comparing-passwords

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.