gpc / grails-hibernate-filter Goto Github PK

View Code? Open in Web Editor NEW

10.0 10.0 37.0 1.51 MB

Home Page: http://grails.org/plugin/hibernate-filter

License: Apache License 2.0

Groovy 81.37% Batchfile 18.63%

grails-hibernate-filter's People

Contributors

Stargazers

Watchers

Forkers

ashneyderman bendoerr clemensschneider oscarks stenix71 beccagaspard asteria277 mdeimel esmoke mattbugbee appcela taktik nitka esauro 409zhangshu raphaelssilva donalmurtagh tarpers juanpablom

grails-hibernate-filter's Issues

Missing table aliases when applying filters to classes with a N-N relationship

Given these 2 domain classes with a many-many relationship between them:

class Condition {

    String name
    Integer status = 1

    static hasMany = [
            problems: Problem
    ]

    static hibernateFilters = {
        published(condition: "status = 1")
        published(collection: 'problems')
    }
}

class Problem {

    String name
    Integer status = 1

    static belongsTo = Condition

    static hasMany = [
            conditions: Condition
    ]

    static hibernateFilters = {
        published(condition: "status = 1")
        published(collection: 'conditions')
    }
}

When I execute this query

        List<Problem> problems = Problem.executeQuery("""
                SELECT          p
                FROM            ${Problem.simpleName} p
                JOIN            p.conditions as c
                WHERE           c.id = ?""", [condition.id])

The generated SQL Is

        select
            problem0_.id as id1_4_,
            problem0_.version as version2_4_,
            problem0_.name as name3_4_,
            problem0_.status as status4_4_ 
        from
            problem problem0_ 
        inner join
            condition_problems conditions1_ 
                on problem0_.id=conditions1_.problem_id 
                and status = 1 
        inner join
            condition condition2_ 
                on conditions1_.condition_id=condition2_.id 
        where
            status = 1 
            and condition2_.id=?

Notice that the status = 1 predicate which is not prefixed with a table alias. Because both the condition and problem tables have a column with this name, the query fails with error

Ambiguous column name "STATUS"; SQL statement:

Collection filters are applied to join table when classes have a N-N relationship

Given these domain classes

class Problem {

    String name
    Integer status = 1

    static belongsTo = Condition

    static hasMany = [
            conditions: Condition
    ]

    static hibernateFilters = {
        statusFilter(condition: "status = 1")
        collectionFilter(condition: 'status = 1', collection: 'conditions')
    }
}

class Condition {

    String name
    Integer status = 1

    static hasMany = [
            problems: Problem
    ]

    static hibernateFilters = {
        statusFilter(condition: 'status = 1')
        collectionFilter(condition: 'status = 1', collection: 'problems')
    }
}

If all the filters are enabled, and this query is executed

Problem.executeQuery("""
    SELECT  p
    FROM    ${Problem.simpleName} p
    JOIN    p.conditions""")

then the generated SQL is

        select
            problem0_.id as id1_4_,
            problem0_.version as version2_4_,
            problem0_.name as name3_4_,
            problem0_.status as status4_4_ 
        from
            problem problem0_ 
        inner join
            condition_problems conditions1_ 
                on problem0_.id=conditions1_.problem_id 
                and conditions1_.status = 1 
        inner join
            condition condition2_ 
                on conditions1_.condition_id=condition2_.id 
        where
            problem0_.status = 1

Notice in the SQL above, that the join table condition_problems is being filtered, rather than the associated collection (the condition table). The query naturally fails, because there is no status column in the join table.

This issue appears to be identical to this Hibernate bug which was opened almost 10 years ago against an early version of Hibernate 3

Although it's claimed that the linked Hibernate issue is a duplicate, I can't find any trace of the original, or any evidence that the problem is fixed in the Hibernate 4 version this plugin is using.

I've pushed a test to this PR that demonstrates the issue.

Configure travis build

Plugin should be built and tests run on every commit

gpc / grails-hibernate-filter Goto Github PK

grails-hibernate-filter's People

Contributors

Stargazers

Watchers

Forkers

grails-hibernate-filter's Issues

Missing table aliases when applying filters to classes with a N-N relationship

Collection filters are applied to join table when classes have a N-N relationship

Configure travis build

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

Jobs