Comments (3)
Do we really want this? 🤔
Here we have already an improvement so applying works for both DSLs.
The only change we could do is:
- resolverClass.set(org.gradle.toolchains.foojay.FoojayToolchainResolver::class.java)
+ resolverClass = org.gradle.toolchains.foojay.FoojayToolchainResolver
But since starting with Gradle 8.2 Kotlin DSL will be the default, I would say the need here is not big enough to add the Groovy DSL to the README.
What do you think?
If you think we still should add it, I'm happy to do that.
I would go with that:
Kotlin DSL
plugins {
id("org.gradle.toolchains.foojay-resolver") version "0.4.0"
}
toolchainManagement {
jvm {
javaRepositories {
repository("foojay") {
resolverClass.set(org.gradle.toolchains.foojay.FoojayToolchainResolver::class.java)
}
}
}
}
Groovy DSL
plugins {
id("org.gradle.toolchains.foojay-resolver") version "0.4.0"
}
toolchainManagement {
jvm {
javaRepositories {
repository("foojay") {
resolverClass = org.gradle.toolchains.foojay.FoojayToolchainResolver
}
}
}
}
from foojay-toolchains.
I would say it should still be added because, even though Kotlin is the preferred DSL, the Groovy DSL is also fully supported with no end of its life in sight.
from foojay-toolchains.
Here we are: #25 🙃
from foojay-toolchains.
Related Issues (20)
- class not found JavaToolchainResolverRegistry when applying plugin in settings.gradle HOT 3
- Gradle corrupt after add this plugin HOT 3
- Proposal: Remove foojay from plugin id as this expose implementation details HOT 1
- I am having the same issue (couldnt find option to open the old issue) HOT 1
- Option to specify that JVM should hava JavaFX bundled HOT 2
- error... reported HOT 3
- 0.4.0 version doesn't work anymore
- Support new GraalVM releases HOT 9
- Error resolving plugin HOT 1
- class o.g.a.i.p.DefaultProject_Decorated cannot be cast to class o.g.a.i.Settings HOT 5
- Improve crafting release notes for new plugin releases HOT 1
- Plugin usage behind artifactory proxy HOT 2
- Plugin should gracefully handle wrong application to a project instead of the settings
- Update Plugin Portal page to reflect that this plugin has to be applied to an settings file HOT 1
- Better handling for broken connection to Foojay backend HOT 11
- Unresolved reference: toolchains HOT 3
- How to know what distributions are available? HOT 1
- Requesting a Java 22 toolchain fails with a strange error HOT 4
- Fix flaky tests \ Improve FoojayApiTest HOT 3
- Add wrapper-upgrade-gradle-plugin
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from foojay-toolchains.