graycoreio / magento2-graphql-introspection-cache Goto Github PK

"Deprecated Functionality: Use of "parent" in callables is deprecated in /app/vendor/graycore/magento2-graphql-introspection-cache/Executor/ReferenceExecutor.php on line 22",

@damienwebdev Is this a weird error to be getting or an expected one? The only place I'm seeing it so far is my local environment, but it definitely sounds like an error which we would expect to see everywhere.

Installed this into a 2.4.5 Community site and got a bunch of integration test failures coming from core and other GraphQl modules.

1) Magento\GraphQlCache\Controller\Catalog\CategoriesWithProductsCacheTest::testRequestCacheTagsForCategoryWithProducts
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 'cat_c'
-    1 => 'cat_c_333'
-    2 => 'cat_p'
-    3 => 'cat_p_333'
-    4 => 'FPC'
+    0 => 'FPC'
 )

I do not think removal of cache tags would be expected for those queries.

There are few more failures coming from the tests for Magento_GraphQlCache.

And also a few more along the lines of the below:

1) Magento\GraphQl\GraphQlIntrospectionTest::testIntrospectionQuery
PHPUnit\Framework\Exception: Warning: Undefined array key "__schema" in /__w/store.***_m2/store.***_m2/dev/tests/integration/testsuite/Magento/GraphQl/GraphQlIntrospectionTest.php:82.

Hey

Installed the extension and ran a build on my PWA Studio project and received the following error:
Trying to invoke protected method GraphQL\\Executor\\ReferenceExecutor::buildExecutionContext() from scope ReflectionMethod

Issue happens in \Graycore\GraphQlIntrospectionCache\Executor\ReferenceExecutor::create

$reflectionMethod = new ReflectionMethod(\GraphQL\Executor\ReferenceExecutor::class, 'buildExecutionContext');
if ($reflectionMethod->isPrivate()) {
    $reflectionMethod->setAccessible(true);
}

I am on Magento 2.4.4-p1 and webonyx/graphql-php is at v14.11.6, and in this version buildExecutionContext is a protected method. Can you simply just add a check for isProtected here as well?

Thanks