greese / dasein-cloud-azure Goto Github PK

When specifying DNS servers in Azure Virtual Networks, both name and IPv4 address is required.
Currently dasein does not take the name as a parameter but instead has a string array of dnsServers.
Should support be handled by string manipulation of this array or would a separate optional parameter make more sense (we could then check that the sizes of the two arrays match if both are provided?)
This will need to go into 2014.07 if signature change is decided.

<Dns>
    <DnsServers>
        <DnsServer name="dns-server-name" IPAddress="IPV4-address-of-the-server"/>
        ...
    </DnsServers>
</Dns>

http://msdn.microsoft.com/en-us/library/azure/jj157181.aspx#dns

Dasein method signature
public VLAN createVlan(String cidr, String name, String description, String domainName, String[] dnsServers, String[] ntpServers)throws CloudException, InternalException {}

https://github.com/greese/dasein-cloud-azure/blob/develop/src/main/java/org/dasein/cloud/azure/compute/image/AzureOSImage.java#L662-L666

My customers are asking me where the affinity group named "EnstratiusAffinityWestUS" came from and "what is 'Enstratius'?" Wouldn't a more generic name work better here?

In AzureLocation.listDataCenters, line 220, change to perhaps:

String name = "Affinity"+(providerRegionId.replaceAll(" ", ""));

(Yeah, I know - picky, picky, picky)

From looking at the code it seems like for Linux VMs an SSH EndPoint is created but for Windows VM the RDP port is set and the WinRM is not set at all.

If the JSON File (getVMResources() ) cannot be read, the Cache return no products.

1 - Ensure to create cache only if valid products where found ?
2 - Add logging error of which file it tried to read (and couldn't find).