gregswindle / cookiemaster-android-lib Goto Github PK

Debug folder should remove from Library/SRC directory.

Found duplicate strings.xml resource file under Library/SRC folder which is already exists under Main/res/values/strings.xml

User story

As a stakeholder,
I need to test the quality of an Android library
In order to assess and ensure quality.

Acceptance criteria

1. Builds must automatically occur and pass.
2. Dependencies are managed.
3. Unit tests and quality measures are executed.

Issue type

• Defect/bug
• Enhancement/feature request
• Feedback, suggestions, or questions

User story

As an engineer,
I need to be sure that source code is covered with tests
In order to assess and approve pull requests.

Acceptance criteria

1. CodeCov integration
2. CodeCov blocks PR merges if coverage isn't 100%

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

Context

Your Environment

• Version used:
• Environment name and version (e.g. Chrome 39, node.js 5.4):
• Operating System and version (desktop or mobile):
• Link to your project:

Expected Behavior

• All code must pass unit tests with 100% coverage.
• This library serves as an example for not only generator-android-library, but also spies, stubs, and mocks.

Current Behavior

com.verizon.api.android.cookiemaster.CookieMaster has 0% coverage.

Issue type

• Defect/bug
• Enhancement/feature request
• Feedback, suggestions, or questions

Expected Behavior

SonarQube should display code coverage results (just as Codecov does).

Current Behavior

SonarQube cannot collect coverage information. See this Travis-CI log for details.

Possible Solution

We might not provide enough information for SonarQube to correlate coverage reports with source code. We get HTML and XML coverage reports, but the jacoco*.exec don't provide data in a way that SonarQube can use.

Steps to Reproduce (for bugs)

1. Checkout the develop branch.
2. Execute the following from the CLI:

$ sonar-scanner -Dsonar.analysis.mode=preview \
                  -Dsonar.github.pullRequest=$TRAVIS_PULL_REQUEST \
                  -Dsonar.github.repository=$TRAVIS_REPO_SLUG \
                  -Dsonar.github.oauth=$GITHUB_ACCESS_TOKEN \
                  -Dsonar.host.url=https://sonarqube.com \
                  -Dsonar.login=$SONAR_TOKEN \
                  -Dsonar.jacoco.reportPaths=library/build/jacoco/testDebugUnitTest.exec \
                  -Dsonar.branch=`git rev-parse --abbrev-ref HEAD`

3. Coverage data will not be sent.

Context

Your Environment

This occurs on workstations and on CI service providers alike.

Issue type

• Defect/bug
• Enhancement/feature request
• Feedback, suggestions, or questions

Expected Behavior

Refactor code to address SonarQube Code Smells:

• 1. Rename constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'
• 2. Add a private constructor to hide the implicit public one.

Current Behavior

See code smells report on develop branch for details.

User story

As an engineer,
I need to quickly assess software products' changes over time
In order to maintain secure dependencies.

Acceptance criteria

1. Products should use Semantic Versioning 2.0.
2. CHANGELOGs should be automatically appended based on either
   2.1. Commit messages or
   2.2. github-changelog-generator

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

Context

Your Environment

• Version used:
• Environment name and version (e.g. Chrome 39, node.js 5.4):
• Operating System and version (desktop or mobile):
• Link to your project: