GithubHelp home page GithubHelp logo

client's People

Contributors

seanlobo avatar vsreekanti avatar

Watchers

avatar avatar

Forkers

seanlobo patrickjdwyer mccreew avinash-arjavalingam

client's Issues

Getting Adjecent Edge Versions of a Node Version

Iā€™m about to implement a get_adjacent_edge_versions method in the client. So far, we only have a method for retrieving adjacent lineage edges. Is it a good idea for me to implement this method, or is the fact that I need it a sign that Iā€™m mis-using Ground? The way I see it, these methods would aid in implementing a Flor query engine for Ground.

Exception raised in get

Exception is raised when attempting to get a node that is not in Ground. Correct behavior should be returning None.

In [3]: gc.get_node('albert')
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
<ipython-input-3-ca0ec4e6f6f0> in <module>()
----> 1 gc.get_node('albert')

~/anaconda/envs/py36/lib/python3.6/site-packages/ground_client-0.1.2-py3.6.egg/ground/client.py in get_node(self, source_key)
    215 
    216     def get_node(self, source_key):
--> 217         return model.core.node.Node(self._get_item("nodes", source_key))
    218 
    219     def get_node_latest_versions(self, source_key):

~/anaconda/envs/py36/lib/python3.6/site-packages/ground_client-0.1.2-py3.6.egg/ground/common/model/core/node.py in __init__(self, json_payload)
      5 
      6     def __init__(self, json_payload):
----> 7         super().__init__(json_payload)
      8 
      9         self._name = json_payload.get('name', '')

~/anaconda/envs/py36/lib/python3.6/site-packages/ground_client-0.1.2-py3.6.egg/ground/common/model/version/item.py in __init__(self, json_payload)
      4 
      5     def __init__(self, json_payload):
----> 6         self._id   = json_payload.get('id') or 0
      7         self._tags = json_payload.get('tags') or {}
      8 

AttributeError: 'NoneType' object has no attribute 'get'

Python: Type checking

The Python client should include type checks to make sure that Strings and Integers are passed in correctly where expected. If not, the error messages will not be very comprehensible.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.