gtk-rs / gobject-subclass Goto Github PK

CC @vhdirk

I'd like to do a first release of this to crates.io, so we have it available from there already when needed somewhere (like in your application or next time I do a gst-plugin-rs release).

Are there any things we should do before that, any changes you'd like to see before?

There are some unsafe traits. With marking a trait as unsafe you say: "watch out, if the implementation of this trait doesn't fullfill all assumptions, then it can cause undefined behaviour". But which assumptions the implementor must respect isn't mentioned.

Can you add documentation adding the assumptions the implementator must respect to not cause undefined behaviour?

https://docs.rs/query_interface/0.3.5/query_interface/

Could simply quite some code and potentially makes the implementation of interfaces simpler (no need for get_impl).

Please add descriptions to the structs, traits and macros in gobject-subclass code.
Thanks :)

GApplication, GInputStream, GOutputStream, GIOStream at least would seem useful