gunpowder-mc / gunpowdermarket

Gunpowder Market

Public Market module

Commands

• /market
  • Opens the market GUI
• /market add <price> [amount]
  • Adds the current item the player is holding to the market

gunpowdermarket's Issues

Market items appearing when using workbench.

Issue

A user in my server reported it. Items being sold on the /market happened to appear when opening the vanilla workbench.

Screenshot

Mod list

Server runs at 1.16.5

• Fabric Loader 0.7.2
• Fabric API 0.32.5
• Fabric Language Kotlin 1.5.0
• Gunpowder Base 0.3.7
• Gunpowder Currency 1.0.2
• Gunpowder Market 1.0.2
• Gunpowder Teleport 1.0.3
• Gunpowder Utilities 1.0.2
• PlayerAbilityLib 1.2.1
• Sodium 0.1.0
• Lithium 0.6.4
• Phosphor 0.7.1

Currency used to purchase things goes to no one

Anything put up on the market has the seller labelled as "DummySeller" and whenever someone purchases an item, the money goes to a player listed in the balance command as "null" instead of the seller.

When items expire on the market, any player can claim those items.

AoF3 2.5.9 NA server.

Problem
When items on the market expire, any player is able to claim any/all expired items.

Expected
Only the player that puts the item on the market should be able to collect their items.

[1.16.5][fabric] Sorting inventory with mouse wheelie mod deletes the entire market

I thought it was a coincidence so I did it again.. Yup.

This to me signals a much bigger problem than just an incompatibility with that inventory sorting mod.

It seems any client has the power to delete the entire market.

[1.17.1] Database Thread/ERROR Stacktrace - Server thread/ERROR Command exception: /market

Whenever we run /market it says "An unexpected error occurred trying to execute that command"

here are my logs - https://paste.shockbyte.com/ihifaqiduyogugeqibek

at line 1800 is where I run the /market command

all my mods are up to date and I have all gunpowder mods

The second page of the market doesn't work

To reporduce the issue fill the market with a bunch of items until the second page is made. Items will appear but they'll be treated clientside as real items you can just add to your inventory, upon clicking them in your real inventory they just disappear. You can't go back to the first page.