gunpowder-mc / gunpowdersignshop

Gunpowder SignShop

Allows for creating custom shops using just signs and containers.

gunpowdersignshop's Issues

Dedicated Server crash when player tries to use Better End sign as a sign shop

AoF 2.5.9 NA Server.

https://paste.lucko.me/8HGIpPwUSc

Description: Ticking entity
java.lang.ClassCastException: ru.betterend.blocks.entities.ESignBlockEntity cannot be cast to net.minecraft.block.entity.SignBlockEntity
at io.github.gunpowder.entities.GunpowderEvents$init$1.trigger(GunpowderEvents.java:46)
at net.minecraft.server.network.ServerPlayerInteractionManager.handler$zdp000$breakCallback(ServerPlayerInteractionManager.java:1049)
at net.minecraft.server.network.ServerPlayerInteractionManager.tryBreakBlock(ServerPlayerInteractionManager.java:248)
at net.minecraft.server.network.ServerPlayerInteractionManager.update(ServerPlayerInteractionManager.java:103)
at net.minecraft.server.network.ServerPlayerEntity.tick(ServerPlayerEntity.java:379)
at net.minecraft.server.world.ServerWorld.tickEntity(ServerWorld.java:621)
at net.minecraft.world.World.tickEntity(World.java:561)

suggestion - buy/sell all option

It would be handy if when right clicking on a sign, it gave you the option to buy or sell all in your inventory or the chest. Other chest/sign shop plugins/mods have this feature, and it would be awesome if GunpowderSignshop could have it as well.

Its fairly limited right now, afaik you can only buy/sell up to a max of 64. So if for example someone had an inventory full of stone that they wanted to sell, they'd have to click the sign and then click confirm 27 times.

Great mod -Just having issues with clicking confirm on a buy or sell because it crashes after that

After I click on confirm it crashes, I can click on the sign and set it up with no problems and seems to work fine until I hit confirm. then the server crashes. with the following errors:

Gunpowder Database Thread/ERROR Error on Database Thread! Please report to the mod author if this is unexpected!

it says "Abort due to constraint violation (UNIQUE constraint failed: Balance.user)"

line 1785 is where run the file here are my logs:
https://paste.shockbyte.com/kavidenefesazazugiqa

Gunpowder crashes server when GunpowderSignshop is getting loaded

I cannot start the server when GunpowderSignshop is installed.
The issue is independent of other Gunpowder mods installed, from what i tested.

I looked at it. This might be an import issue or something wrong with the java on the server.

Full crash message:
https://pastebin.com/CeHUfqAt

Fatal error :(

latest.log My bad, this is not what I want to post, sorry.

Ability to specify quantity to sell

The only way I could see to specify the quantity is to make sure the first slot on the container has the stack set to the desired quantity. It would be nice if players could specify the quantity they wish to sell for as well on the sign. This may take up an additional line of text, so to combat this I have a suggestion:

Signs only use the first line for buy/sell and quantity numbers. Using [gp:1:32] would sell 32 quantity for $1. Formatting may be adjusted to require the $ in the line, or swapped in order. This would limit the price more than using a separate line for the price, down to only 10k but can be adjusted by using 'b' instead of 'buy', and now allows for 3 lines of formatting for the players. Obviously this would break all existing signs, so a converter would be needed to upgrade old signs. Probably won't be implemented since it requires extra work, but I figured I would suggest it before forking the project and making the changes myself.

Ability to distinguish different NBT tags

Being able to differentiate between items tagged with different nbt data would open a lot of doors for server owners. I.E. Im trying to make different player heads worth different amounts of currency, and if gunpowder respected NBT tags I could do just that, but because it only registers any given player head as minecraft:player_head it cannot, and we are limited to using player head as 1 form of currency

Dyes breaking signs

MC Version 1.18.1 GP SS ver 1.0.8
Signs can be dyed by other players and in most cases this breaks the sign used to GP Signshop.
This also works with glow sacs and other various methods of changing sign text color or behavior

buy signs not linking

so im using sign shops gunpowder and gunpowder currency. currently, i am able to get the admin shops to work properly but when players try to use the normal [gp:buy] sign it tells them its not linked to storage and makes the sign go poof. i placed a chest then put the item in the first slot then right-click the chest with the gold nugget and get the message marked container @ xyz then place a sign with [bgp:buy] $(cost) on next line then item type on next line of the sign... the sign turns blue and states im selling x of y but then when people try to use it they are told its not linked to storage of any kind

is there a permissions node for the standard use of buy sell signs? even as Op the sign doesnt seem to function unless its an [gp:adminbuy] sign

Cannot confirm signshop action in Gunpowder Signshop 1.0.1

Hi there,
Unfortunately I'm having an issue with the most recent version of signshop. I can complete all of the steps necessary to create a signshop, but as soon as I try to confirm a purchase or a sale of an item by pressing the [Confirm] option, nothing happens apart from "gpss_confirm" being sent in chat by the user who sent it. I'm not sure if this is an issue caused by upgrading the signshop mod and not changing something, or if it's anything else.
Thank you for your time and hardwork!

Attached is a screenshot of the issue at hand.

[Bug] Signshop not checking for additional data before selling

Basically you can make a shop with OP armor, lets say a diamond helmet with the best enchantments, and when you set up the shop, you can put inside plain un-enchanted helmets, when you buy from that shop you'll get the OP helmet that was listed instead of saying "there is no stock", basically duping enchants.

LootableBlockEntityMixin_Signshop#markRemoved() does not call super.markRemoved()

It is important to call super.markRemoved() as otherwise the blockentity will go into a state where it is not in the world but parts of the code will assume that it is in the world.

I found this after debugging for several hours. I think this is a likely cause of an issue with Lithium's hopper optimizations, which relies on BlockEntity#markRemoved() being called when blockentities become inaccessible to hoppers (CaffeineMC/lithium-fabric#247)

Crash on buying something

When i try and buy something from a shop i get this error:

https://hastebin.com/kavekirewe.properties

And the server crashes. Also i cant seem to make to admin sale signs.