GithubHelp home page GithubHelp logo

gviswanathan / html5sortable Goto Github PK

View Code? Open in Web Editor NEW

This project forked from lukasoppermann/html5sortable

0.0 2.0 0.0 1.12 MB

Lightweight jQuery plugin to create sortable lists and grids using native HTML5 drag and drop API.

JavaScript 70.37% HTML 29.63%

html5sortable's Introduction

HTML5 Sortable jQuery Plugin

Build Status Coverage Status Git Release Bower NPM

Lightweight jQuery plugin to create sortable lists and grids using native HTML5 drag and drop API.

Features

  • Less than 1KB (minified and gzipped).
  • Built using native HTML5 drag and drop API.
  • Supports both list and grid style layouts.
  • Works in IE 5.5+, Firefox 3.5+, Chrome 3+, Safari 3+ and, Opera 12+. (needs testing)
  • Supports exports as AMD, CommonJS or global
  • Comes with an AngularJS directive help wanted

Demo: Check out the examples

Installation

The recommended way, using Bower:

bower install html.sortable —save

The non-Bower way:

include html.sortable.x.y.z.js or the minified version, html.sortable.min.x.y.z.js.

Install via NPM:

npm install html.sortable —save

Examples

You can find the examples online or test locally.

# To get the local examples to work do the following:
git clone https://github.com/voidberg/html5sortable
cd html5sortable
bower install

Build it / Hack it

1. Node package manager (npm)
You will need npm, choose any way you like to install npm.

2. Clone and install the project

git clone https://github.com/voidberg/html5sortable
cd html5sortable
npm install && bower install

3. Commit
If you send a pull request make sure it passes the tests & linting. Please do NOT bump the version number.

npm test

Note: At the moment you will get the following warnings, if your PR does not add any other warning, it is considered to have passed:

  • 2x This function has too many statements. (for src/html.sortable.js)
  • 2x Line must be at most 80 characters (for src/html.sortable.js)

We are going to fix those linting issues in the near future.

4. Merging PRs and building (only if you have commit rights)

After merging a PR run the following command to build the minified versions and bump the version number.

npm run build

Usage

Use sortable method to create a sortable list:

$('.sortable').sortable();

Styling

Use .sortable-placeholder CSS selectors to change the styles of the placeholder. You may change the class by setting the sortableClass option in the config object.

$('.sortable').sortable({
  sortableClass: 'my-placeholder fade'
});

Events

sortstart

Use sortstart event if you want to do something when sorting starts:

$('.sortable').sortable().bind('sortstart', function(e, ui) {
    /*

    This event is triggered when the user starts sorting and the DOM position has not yet changed.

    ui.item contains the current dragged element.
    ui.startparent contains the element that the dragged item comes from

    */
});

sortstop

Use the sortstop event if you want to do something when sorting stops:

$('.sortable').sortable().bind('sortstop', function(e, ui) {
    /*

    This event is triggered when the user stops sorting. The DOM position may have changed.

    ui.item contains the element that was dragged.
    ui.startparent contains the element that the dragged item came from.

    */
});

sortupdate

Use sortupdate event if you want to do something when the order changes (e.g. storing the new order):

$('.sortable').sortable().bind('sortupdate', function(e, ui) {
    /*

    This event is triggered when the user stopped sorting and the DOM position has changed.

    ui.item contains the current dragged element.
    ui.index contains the new index of the dragged element (considering only list items)
    ui.oldindex contains the old index of the dragged element (considering only list items)
    ui.elementIndex contains the new index of the dragged element (considering all items within sortable)
    ui.oldElementIndex contains the old index of the dragged element (considering all items within sortable)
    ui.startparent contains the element that the dragged item comes from
    ui.parent contains the element that the dragged item was added to (new parent)

    */
});

Options

items

Use items option to specifiy which items inside the element should be sortable:

$('.sortable').sortable({
    items: ':not(.disabled)'
});

handle

Use handle option to restrict drag start to the specified element:

$('.sortable').sortable({
    handle: 'h2'
});

forcePlaceholderSize

Setting forcePlaceholderSize option to true, forces the placeholder to have a height:

$('.sortable').sortable({
    forcePlaceholderSize: true
});

connectWith

Use connectWith option to create connected lists:

$('.js-sortable, .js-second-sortable').sortable({
    connectWith: 'connected' // unique string, which is not used for other connectWith sortables
});

placeholder

Use placeholder option to specify the markup of the placeholder:

$('.sortable').sortable({
	items: 'tr' ,
	placeholder : '<tr><td colspan="7">&nbsp;</td></tr>'
});

Methods

destroy

To remove the sortable functionality completely:

$('.sortable').sortable('destroy');

disable

To disable the sortable temporarily:

$('.sortable').sortable('disable');

enable

To enable a disabled sortable:

$('.sortable').sortable('enable');

reload

When you add a new item to a sortable, it will not automatically be a draggable item, so you will need to reinit the sortable. Your previously added options will be preserved.

$('.sortable').sortable();

AngularJS usage

HELP WANTED: If you know angular and want to help get this package up to date and cleaned up, please contact me (lukasoppermann) or start submitting PRs.

Make your app use the htmlSortable module. Assign html sortable options to the html-sortable tag, specify an ng-model and, optionally, specify a callback using html-sortable-callback.

$scope.sortableOptions = {
	placeholder: '<div class="sortable-placeholder col-md-3"><div></div></div>',
  	forcePlaceholderSize: true
};

$scope.sortableCallback = function (startModel, destModel, start, end) {
	// ...
};
<ul html-sortable="sortableOptions" html-sortable-callback="sortableCallback" ng-model='data1'>
	<li ng-repeat="itm in data1">
   		{{itm}}
   </li>
</ul>

See the examples for more information.

Authors

Original code by Ali Farhadi. This version is mantained by Alexandru Badiu & Lukas Oppermann.

Contributors

Thanks to all the people who contributed fixed and improvments. To get a full list of contributors, check out the AUTHORS file.

Contributing

When sending pull requests make sure to only include changes that directly relate to the fix/feature you are adding and also start a pull request from a freshly cloned copy of the repo to make it easy to merge.

Please always rebase to a single commit with a descriptive name and an explanation of why what was changed.

If you sent a pull request and it got merged, your name will automatically be added to the AUTHORS file with the next release.

NOTE: Please do NOT add your name to the AUTHORS file and do NOT bump the version as this will be done automatically.

Comment your code

Your code should be as self-documenting as possible, but because this is an open source project with multiple contributors please add comments whenever possible.

Docblocks for functions

Every function should have a docblock above stating what the function does and what parameters it is supposed to get.

/*
* remove event handlers from sortable
* @param: {jQuery collection} sortable
*/

Comment on individual lines

You do not need to comment on everything you do, but if you make a decision that could be confusion or something could be potentially seen as an error (e.g. because it is not the default way or not the most obvious way) please comment on why you did this. This prevents people from “fixing” stuff that is not broken and maybe breaking things because of this.

Add tests

Please add tests using mocha and jsdom, to verify & test your changes. Make sure to make your test fail first, so you are sure they work. Since tests are very important, your PR is going to be failed by coveralls, if you do not include tests.

If something is hard to test, you probably need to refactor it into multiple small functions. This is one of the good effects of testing, it improves your code quality.

Just add a new .js file to the test folder, or add a test to one of the files that already exist.

Styleguide

While the code does not pass the linking yet, we are working on it. Please ensure your code does pass our linting.

Take care to maintain the existing coding style. Lint and test your code using npm test.

Keep lines as short as possible (max. 80 characters)

Keeping your lines short makes it much more easy to spot errors and for other developers to scan the code.

Keeping to an 80 character limit makes you think more about how to code something and often forces you to refactor and simplify your code.

Lastly, less character per line, mean less potential merge conflicts.

Don’t use multiple var declaration (except for-loop)

BAD:
var $sortable = $(this), index, placeholder;

Good:
var $sortable = $(this);
var index;
var placeholder;

While a little verbose, declaring one variable per line makes the code much more easy to scan. Additionally this helps when merging PRs.

Don’t use chaining

BAD:
var $item = $(this).attr(‘draggable’, method === ‘enable’);

Good:
var $item = $(this);
$item.attr(‘draggable’, method === ‘enable’);

jQuery makes it easy to chain things together, while this can be a nice feature it makes the code less maintainable, harder to read and harder to understand. Don’t use chaining.

jQuery Collections should be prefix with a $

var $sortable = $(this);

The prefixing of variables that store jQuery collection ensures that developers have an easy time differentiating between jQuery collections and other variables.

Don’t use else if, try to avoid else

// This:
if( a === b){
  
} else if ( a === c){
  
}

// Actually means this:
if( a === b){
  
} else {
	if ( a === c){
    
	}
}

else if does not exists in javascript, so do not use it.

If at all possible, also try to refrain from using else.

if( a === b){
  return 
} else {
  return 
}

// Could be refactor to
if( a === b){
  return 
}
return 

Reduce parameters (max. 3)

Never use more than 3 parameters, this will keep you from falling into bad habits. If you need complex configuration (which you should try to avoid), use an object.

Reduce nesting depth (max. 3)

Do not nest to deeply. This will make the code confusing, hard to read and again, make merging hard. If your code gets to complex, try to refactor parts out into individual functions.

Roadmap

If you want to help us by working on any of the points below, please let me know and I add you and your branch to the list.

  • clean up & add comments (wip)
  • mocha tests (wip)
  • Refactor & break code into functions (wip)
  • Nesting via drag & drop
  • refactor to have gulp create
    • jQuery version
    • plain js version
  • use css framework for examples
  • make this compatible with
    • plain js
    • amd
    • commonjs

License

Released under the MIT license.

html5sortable's People

Contributors

adamnowotny avatar andyburke avatar batista avatar bistoco avatar coreyfarrell avatar egorkhmelev avatar eheikes avatar farhadi avatar flying-sheep avatar frozzare avatar jacobsvante avatar makepanic avatar omghax avatar oscargodson avatar polyfloyd avatar rwoverdijk avatar satazor avatar sfarthin avatar spalenza avatar ssafejava avatar

Watchers

 avatar  avatar

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.