gwtplus / google-gin Goto Github PK

https://about.sonarcloud.io/

Will require some additional reporting plugins like findbugs, checkstyle and pmd

When new version of Guice is released.

So that Java 9/10 build is not released to central when we want to keep Java 8 compatibility.

Use maven enforcer

GWT Generators are going away in GWT 3 / j2cl. They only way forward is apt. The added benefit of migration would be out of the box support for non GWT projects like Java and Android ones.

However there are sharp alternatives supporting JSR-330:

• google/dagger as a base
• google/auto/factory for assisted inject

but some Gin / GWT specific features are not supported by them:

• GWT-RPC Sync / Async interfaces
• AsyncProvider interface

More on the issue here: GWT 3 and Gin

Consider either migration to apt or creation of dagger extensions to support GWT specific features.

Originally reported on Google Code: #199 / #199

What steps will reproduce the problem?
According to the Guice injection points document at: guice/wiki/InjectionPoints injection methods of super classes are called before the methods of a subclass.

In Gin methods are sorted alphabetically meaning that some methods in sub class maybe called before methods from super class.

What is the expected output? What do you see instead?
I expect order of invocation as described in Guice Wiki

What version of the product are you using? On what operating system?
GWT 2.6.1 / GIN 2.1.2

Please provide any additional information below.
zip file with a test case attached in the original issue comments section

The project miss information what was changed since 2.1.

As suggested in: #deprecated-oss-parent projects should either maintain own parent pom or duplicate the configuration in own pom.

And how it could benefit developers with the migration to Dagger

More on this here: google-gin/D0YLieFtPSA/4x6nlSDQCQAJ

Binder.requireAtInjectOnConstructors()
DaggerAdapter

To verify that gin builds with those. We still want to preserve jdk8 compatibility.

Guice supports jdk9 with v4.2.0: google/guice#1085

Also add:
Automatic-Module-Name: com.google.gwt.inject