gwynethsc / step Goto Github PK

Considered type='number' with but dropdown filtering is inconvenient

I would suggest just spelling out type and property instead of just the letters, for better readability.

Originally posted by @sperzion in #11

Possible fix for intermittent incomplete "Delete All" action; sometimes, the displayed comments immediately after pressing "Delete All" include some comments that should have been deleted; they disappear upon refresh. Comments are additionally confirmed to have been deleted in Datastore.

Suspected to be a race condition issue; transactions may prevent UI change until all comments are deleted. Then again, maybe not desirable to have to wait? Perhaps a better strategy to have a continuous update, or at least a "processing" signal in the UI

Not something you need to handle now, just more of a learning point for the future. When making calls to the server, you should also check for errors/failures. That way you can show a nice toast/popup message if for some reason the delete fails.

Another learning point, you do not need to reload your all your comments on delete. You could potential just verify the response was successful and use javascript to remove that one comment or all comments. This makes your website snappier and prevents excess calls to your server/database.

Again, you don't need to make these changes, I just wanted to give you some advice on what to research if you wanted. to improve your current implementation.

Originally posted by @Google-JM in #14

tiny CSS fix, as per title

enable (unique?) username selection and editing
enable profile image upload
enable user default settings, such as number of comments displayed

specifically, when the number of comments exceeds the max number displayed

Consider FetchOptions offsets and cursors

I think a better name would be redirectUrl. logURL could be confused with logging.

Originally posted by @Google-JM in #21

EDIT:
discussed, changing to "authenticationURL", passing an actual "redirectURL" as a constructor parameter

I would also recommend refactoring the code into separate functions for readability. Typically, you'll want your function / method implementations as granular as possible for ease of understanding and maintenance.

So, for example, in this case, you might consider having a function like hideElement like Justin recommended, but another one that is a level higher, like showLogIn(boolean) to toggle visibility of the log in UI. This function could make use of your hideElement function.

Originally posted by @sperzion in #21

Ignores optional attendees

Consider JavaScript regular expressions for validation

In the future think about how you would display this error to the user, if it is human readable.

Originally posted by @Google-JM in #35

Encountered intermittently when sending GET requests to /data and /login servlets during comment deletion

of course, must still include all mandatory attendees

considers optional attendees on an all-or-nothing basis

such as:
number of comments to display
default hide/show
login status?

Datastore has a limit (500? 1000?) on the maximum possible number of entries that can be simultaneously deleted; requires additional logic to loop through for thorough deletion.

Low-priority - high traffic not anticipated on this site

I missed this is previous reviews, but something to think about if you have time to come back to this code:

Create a User object to hold userId, userEmail. That way you can do LoginStatus(User user, boolean loggedIn, String redirectUrl)

Loose rule of thumb if you are passing 2 or more params that are similar, think about creating an object to hold the values.

Originally posted by @Google-JM in #35

Has inconsistently occurred after each of page reload, comment submission, delete all, and login. Delete buttons usually return upon further actions, such as page reload, comment submission.

This is good for this PR, but a slightly more sophisticated approach would be to check what type of error you're getting. If you know it's the intermittent kind, you could do the backoff, whereas if you know it's something that's never going to work no matter how many times you try, you could just stop.

Originally posted by @sperzion in #44