gygrazok / witchmod Goto Github PK

Title.

I loved this mod when it was working, and it's a shame that it's broken at the moment.

Is there any possibility you could look into fixing this mod for the latest STS release?

Thank you!

For no reason I could understand (I dont know anything about java code though), Witch mod crashes
(Log window displays a few lines, screen goes black as if game was about to start, then back to the log window).
I tried to understand the crash log and find references over the web, but it's way out of my understanding.
I posted the log on pastebin since it's quite long, and took a screenshot of my ModTheSpire start panel.
If any more info is required, do ask.

I'm completely new to GitHub and feeling a bit lost; I'm sorry if my message is not at the right place or anything of that sort :/

MTS screenshot : https://i.postimg.cc/yNy16Nn5/Capture.png
MTS log : https://pastebin.com/3EYRZ9Zj

When choosing the "upgrade all strikes and defends" option, none of the Witch's strikes or defends get upgraded. I've noticed most modded characters having this issue.

Oddly, looking through your code I don't see why it's not working. Is poison stacks passed by reference for some reason?

Fighting pair of elites that put burns in deck in Act 3. Deck has an unupgraded mystic burial and discard has an upgraded mystic burial.

3/3 repro
turn 1: Malady right, defend, soul barrier+, mystic unburial twice (defend), pain bolt right
turn 2: Mortuus claw+ left, Runic Fang+ left, Defend
Remaining enemy then uses put burns in deck attack and exception is hit

WITCH.autosave.zip

Enabled Mods: Base Mod, Always Neow, Witch

Exception in thread "LWJGL Application" com.badlogic.gdx.utils.GdxRuntimeException: java.lang.StackOverflowError
at com.badlogic.gdx.backends.lwjgl.LwjglApplication$1.run(LwjglApplication.java:133)
Caused by: java.lang.StackOverflowError
at witchmod.cards.MysticUnburial.canUse(MysticUnburial.java:36)
at witchmod.cards.MysticUnburial.canUse(MysticUnburial.java:38)
at witchmod.cards.MysticUnburial.canUse(MysticUnburial.java:38)
at witchmod.cards.MysticUnburial.canUse(MysticUnburial.java:38)

Cast 2 Baleful Ward and had my block get broken. Only received 1 copy of Baleful Ward the following turn.

I've made sure everything is up to date and the button for the Witch does show up but when I embark it switches me to Ironclad. Made sure the WitchMod.Jar and witchmod-1.0 are in the mods folder but it keeps switching me.

00:38:40.234 INFO dungeons.AbstractDungeon> Generating seeds: -5253865443519082395
00:38:41.231 INFO basemod.BaseMod> publishPreStartGame
00:38:41.232 INFO basemod.BaseMod> hooking into character creation
00:38:41.232 INFO basemod.BaseMod> creating character WITCH
00:38:41.345 INFO unlock.UnlockTracker> Already seen: BlackCat
00:38:41.348 INFO unlock.UnlockTracker> Already seen: BlackCat
00:38:41.379 INFO unlock.UnlockTracker> Already seen: BlackCat
00:38:41.481 ERROR basemod.BaseMod> could not instantiate witchmod.characters.WitchCharacter with the constructor witchmod.characters.WitchCharacter
00:38:41.486 INFO basemod.BaseMod> running as the Ironclad instead
00:38:41.487 ERROR basemod.BaseMod> error was: null

This is what I found in the log immediately after I attempt to embark. I'm not sure what I'm doing wrong exactly.

I've tried with and without unzipping witchmod-1.0 but still didn't work.

I've also started fresh and made sure to follow all instructions exactly and still no luck. Same error.

Black Cat should only give curses with the curse rarity, so that you can't get pride, other mod's special curses, and reduces the number of prohibited cards already in the code.

Also maybe change it so that instead of prohibiting pain and such, you let the player choose between 2 curses at battle start.

Maybe this is a known issue.

After I won my first and only run with the witch, the run is shown in the run history.
The statistics view however shows highest score as 0 with 0 victories and floors climbed 46 bosses slain 2

can't find it at all

I expected it to ignore the cost of the X card, similar to Havoc, but it depleted all my energy instead

Start of fight vs Nemesis. Cast owl to draw 2 cards and then tried to cast fatal ray. Game then froze.

Exception in thread "LWJGL Application" com.badlogic.gdx.utils.GdxRuntimeException: java.lang.NoSuchMethodError: com.megacrit.cardcrawl.vfx.combat.MindblastEffect.(FF)V
at com.badlogic.gdx.backends.lwjgl.LwjglApplication$1.run(LwjglApplication.java:133)
Caused by: java.lang.NoSuchMethodError: com.megacrit.cardcrawl.vfx.combat.MindblastEffect.(FF)V
at witchmod.cards.FatalRay.use(FatalRay.java:38)
at com.megacrit.cardcrawl.characters.AbstractPlayer.useCard(AbstractPlayer.java:1476)
at com.megacrit.cardcrawl.actions.GameActionManager.getNextAction(GameActionManager.java:294)
at com.megacrit.cardcrawl.actions.GameActionManager.update(GameActionManager.java:148)
at com.megacrit.cardcrawl.rooms.AbstractRoom.update(AbstractRoom.java:258)
at com.megacrit.cardcrawl.dungeons.AbstractDungeon.update(AbstractDungeon.java:2674)
at com.megacrit.cardcrawl.core.CardCrawlGame.update(CardCrawlGame.java:893)
at com.megacrit.cardcrawl.core.CardCrawlGame.render(CardCrawlGame.java:466)
at com.badlogic.gdx.backends.lwjgl.LwjglApplication.mainLoop(LwjglApplication.java:225)
at com.badlogic.gdx.backends.lwjgl.LwjglApplication$1.run(LwjglApplication.java:126)

Game crashed when entering the first fight of the run aka first room after Neow.

Exception in thread "LWJGL Application" com.badlogic.gdx.utils.GdxRuntimeException: java.lang.NoSuchMethodError: com.megacrit.cardcrawl.actions.common.MakeTempCardInDrawPileAction.(Lcom/megacrit/cardcrawl/core/AbstractCreature;Lcom/megacrit/cardcrawl/core/AbstractCreature;Lcom/megacrit/cardcrawl/cards/AbstractCard;IZZ)V
at com.badlogic.gdx.backends.lwjgl.LwjglApplication$1.run(LwjglApplication.java:133)
Caused by: java.lang.NoSuchMethodError: com.megacrit.cardcrawl.actions.common.MakeTempCardInDrawPileAction.(Lcom/megacrit/cardcrawl/core/AbstractCreature;Lcom/megacrit/cardcrawl/core/AbstractCreature;Lcom/megacrit/cardcrawl/cards/AbstractCard;IZZ)V
at witchmod.relics.BlackCat.atBattleStartPreDraw(BlackCat.java:36)
at com.megacrit.cardcrawl.characters.AbstractPlayer.applyStartOfCombatPreDrawLogic(AbstractPlayer.java:2166)
at com.megacrit.cardcrawl.rooms.AbstractRoom.update(AbstractRoom.java:237)
at com.megacrit.cardcrawl.dungeons.AbstractDungeon.update(AbstractDungeon.java:2615)
at com.megacrit.cardcrawl.core.CardCrawlGame.update(CardCrawlGame.java:825)
at com.megacrit.cardcrawl.core.CardCrawlGame.render(CardCrawlGame.java:376)
at com.badlogic.gdx.backends.lwjgl.LwjglApplication.mainLoop(LwjglApplication.java:225)
at com.badlogic.gdx.backends.lwjgl.LwjglApplication$1.run(LwjglApplication.java:126)

Thanks for letting me know on the update for the mod but now with the updated version it says it requires ModTheSpire v3.3.0. I've been digging for hours making sure everything is up to date but I have not found anything higher than 3.2.0 for MTS. Am I just missing it or looking in the wrong place? As of right now I can't even select the mod within the MTS launcher.

I had 5 frail from Spheric Guardian.
Mercury wand showed the same number for attack and defend of 9
I did actually receive 9 block on casting it while only receiving 3 from a regular defend card.

Edit: Was mistaken. There were 2 mercury wands and I was confusing the upgraded one (13) giving 9 when debuffed

My Witch runs show up in the Run History section of the game with no filters selected. However, when I go to filter by class, to see just the Witch runs only, the game doesn't detect any runs.

I had the probably inadvisable idea of turning on a few character mods, then playing a game with the modifier that gives you cards from all classes.
Wretched Nails was added to my deck by the Replay the Spire elite that thickens your deck. Later in the fight when I drew cards at the start of the turn, the game closed. This is in the error log:

java.lang.ClassCastException: com.megacrit.cardcrawl.characters.Ironclad cannot be cast to witchmod.characters.WitchCharacter
	at witchmod.cards.WretchedNails.calculateModifiedCardDamage(WretchedNails.java:80) ~[WitchMod.jar:?]
	at witchmod.cards.WretchedNails.applyPowers(WretchedNails.java:56) ~[WitchMod.jar:?]
	at com.megacrit.cardcrawl.cards.CardGroup.applyPowers(CardGroup.java:183) ~[?:?]
	at com.megacrit.cardcrawl.characters.AbstractPlayer.onCardDrawOrDiscard(AbstractPlayer.java:1459) ~[?:?]
	at com.megacrit.cardcrawl.characters.AbstractPlayer.draw(AbstractPlayer.java:1825) ~[?:?]
	at com.megacrit.cardcrawl.actions.common.DrawCardAction.update(DrawCardAction.java:100) ~[desktop-1.0.jar:?]
	at com.megacrit.cardcrawl.actions.GameActionManager.update(GameActionManager.java:152) ~[?:?]
	at com.megacrit.cardcrawl.rooms.AbstractRoom.update(AbstractRoom.java:257) ~[?:?]
	at com.megacrit.cardcrawl.dungeons.AbstractDungeon.update(AbstractDungeon.java:2635) ~[?:?]
	at com.megacrit.cardcrawl.core.CardCrawlGame.update(CardCrawlGame.java:825) ~[?:?]
	at com.megacrit.cardcrawl.core.CardCrawlGame.render(CardCrawlGame.java:419) [?:?]
	at com.badlogic.gdx.backends.lwjgl.LwjglApplication.mainLoop(LwjglApplication.java:225) [?:?]
	at com.badlogic.gdx.backends.lwjgl.LwjglApplication$1.run(LwjglApplication.java:126) [desktop-1.0.jar:?]

Plenty of other witch cards worked fine for me (Mercury Wand, Bewitch, Mortus Claw, etc) so the issue is probably specific to this card.

When choosing which mods to enable in ModTheSpire window, your mod is highlighted yellow with commentary "this mod explicitly supports week 25 patch", despite it being updated to the latest version. The game was successfully launched. I am not sure if this is a problem from your side, but just maybe to take a quick look at it if no other issues are at hand would increase the mod's appearance of reliability.

the card says it halves your block, but it exhaustes without halving block

Text doesn't change when cleansed. When played allows a target as if it was the attack but just exhausts and damages for 1. Possible issue with blue candle?

Can you add the SlayTheSpire-mod github tag to the repo? That will help people be able to browse and find mods more easily

if you draw wretched nails in the first turn of combat, it deals 5 extra damage. all other turns are normal

Cast Mystic Unburial+ and given the choice of Zombie Spit+(0 cost) and Decrepify+(X cost). It seems like it is filtering out all the cards that I don't have mana to cast (currently at 0 mana) despite Mystic Unburial being upgraded and letting me ignore cost. Lots of 1 to 3 cost cards in the discard that aren't being shown.

In particular in this instance, Replay The Spire's Delirium curse, which randomizes card-costs for one turn, doesn't seem to work appropriately for the Witch. SPECIFICALLY the Witch, which was strange to me! I tested this with both another modded character and a vanilla character and it only didn't work for the witch. I know it's not exactly you guys' job to fix these interactions but since it seemed specific to Witch and not, in this example, Mad Scientist or anything else, that you'd be the ones to go to.

Expected Behavior

The Flight counter is either reduced by 1 after the card is played or the Byrds take the full 4 damage.

Actual Behavior

The Flight counter is not decremented when Bleed Out is used. Also, they will only take 2 damage when in Flight.

Steps to Reproduce the Problem

1. Fight the Byrds
2. Use Bleed Out

Specifications

• Version: v1.0-rc1, latest BaseMod, latest stable version of the game
• Platform: Window 8.1 x64

Have regret in my actual deck. Black cat gave parasite at the start of the fight but du-vu is only giving +1 strength on the first turn of combat

Expected Behavior

The card I select to remove is removed from my deck.

Actual Behavior

A copy of the card I select is added to the deck. This occurs with any card selected, and is repeatable when I reload the save.

Steps to Reproduce the Problem

merchant remove bug.zip

1. Load the attached save. Mods active:
   BaseMod
   ReplayTheSpire
   FetchMod
   ColoredMap
   TheWitch
2. Remove a card from the shop.

Video of the behavior:
https://streamable.com/fh5ro

Specifications

• Version: v1.0-rc1, latest BaseMod, latest stable version of the game
• Platform: Window 8.1 x64

Since the witch starts with the black cat delirium form is often bad for your character. It provides the opportunity to draw the curse the black cat shuffles in. Some of the more formidable examples are: pain, regret, normality, shame, doubt. Drawing into any of those is bad news bears.

So I like the concept of the power, but it's best placed with another character. The witch can just get screwed over because of it...

Appears to not apply decrepit properly when you have strength. Not sure how it's working right now. If you have no idea what it is I can test more and get back to you.

Since the newest Update (Beta and non Beta build) the game crashes right before it gets to the menu, after the Megacrit screen.
It only happens if you have a character mod checked in the Modloader.

Here is a picture of it,

This definitely isn't an issue. I just noticed you don't have a form card in the mod. Was just wondering if you could add one to keep the form cards going. That's all :)

no errors are thrown, but playing roiling barrier is putting it into the discard pile, it may be related to the issue in class selection, I had to run using the diverse modifier to even get the card
18:15:01.374 INFO basemod.BaseMod> publish on card use
18:15:02.307 INFO helpers.TipHelper> ! block

Expected Behavior

The Ring of Panic relic, from the Replay the Spire mod, applies the Confusion debuff at the start of the player's turn.

Actual Behavior

The Confusion debuff appears as a power, but none of the cards in your hand have different energy values. In essence, it's free energy.

Steps to Reproduce the Problem

1. Start new game
2. Add the Ring of Panic relic to your character via console
3. Enter combat

Specifications

• Version: v0.6.7 of mod, ModTheSpire 2.7, 06-21-2018 main branch
• Platform: Windows 8.1 x64

Hello, I just found out a bug that the effect Decrepit is not applying to the card Harmlessness when it is cleansed. The effect applies well in my other cards. Thanks!

So far I've gotten it twice and both times it crashed. Unsure if it's directly related to that option or a specific card I was transforming into (both times I picked a strike and a defend to transform)