gyrus / lock-pages Goto Github PK

If upgrading the plugin (not installing it fresh), the array key for post types doesn't get added to the settings, which throws a notice on each admin page load.

It's fixable by going back to the options page and re-saving, but could be fixed in code as well. I added this to the load_options function to fix it automatically:

/**
 * Add empty array for post types if not present.
 * @since   0.3.1
 */
if ( ! array_key_exists( $this->prefix . 'post_types', $the_options ) ) {
    $the_options[ $this->prefix . 'post_types' ] = array();
    update_option( $this->options_name, $the_options );
}

It looks like I can filter this (by overriding the entire menu item), but would it not be more suitable to use manage_options here?

I'm running Bedrock, so even admins on my live environment don't have the update_core capability, which means i'm currently unable to access the options page.

Also, any progress on preventing the editing of post/page content (e.g. #1). Looks like you're hesitant to add this in? I can build on @jezhumble's fork and add in a 'lock content' option in the options page as you suggested, so long as you'll consider merging with the main git + wp repos (it would be nice if I could keep using wpackagist, rather than pulling from another repo).

Cheers

Fork: github.com/thomasfw/Lock-Pages
Commit: a2e2dd2b5c1e293205e046c48bd3f012e0b29a8

This fork includes the ability to disable the editing of post/page content on a per-post basis, blocks the revisions screen for posts with locked content, and includes the admin cap filter as discussed here.

Annoyingly I started out on the 3.0 release found in the wp plugin repo/wpackagist, so the changes you've added in 3.0.1 aren't included.

If I get more time I will merge the changes in your 3.0.1 and fix the conflicts with my fork so I can submit a pull request.

This function uses $_GET['action'] when $screen = get_current_screen() returns an object $screen->action that seemingly could be used instead. Is there a reason for preferring $_GET['action'] over $screen->action?