GithubHelp home page GithubHelp logo

Comments (6)

gyscos avatar gyscos commented on May 27, 2024

Hi, and thanks for the report!

Unfortunately it's not trivial to know a layer is hidden. Layers can be transparent and only draw on part of their allocated rectangle, which makes it harder to know when we can guarantee a layer is not visible.

Note that if you have a bunch of fullscreen layers, you might not actually need them all in the same stackview. For example ScreensView is meant to show one (fullscreen) view at a time (and that fullscreen view can be a StackView). One is already embedded in the Cursive root: you can call Cursive::add_screen to create new, separate screens, and then decide which one to show. This will properly skip layout and draw calls for non-active screens.

from cursive.

smallB007 avatar smallB007 commented on May 27, 2024

Probably very naive, but would adding flag is_hidden solve that issue?

from cursive.

gyscos avatar gyscos commented on May 27, 2024

You can already wrap some view in a HideableView and toggle that on/off. You could absolutely do this for any full-screen layer you add.

But if you add a non-transparent full-screen layer to the StackView on top of other stuff, chances are a new screen is what you need.

from cursive.

smallB007 avatar smallB007 commented on May 27, 2024

I am not sure, but "I think" that hideable view blocks input to views "under" it? I remember I wasn't happy the hideableview's concepts were implemented. In my own code base I simply added flag is_hidden to a view and if view is hidden stack "skips it" completely. Simple but works.

from cursive.

gyscos avatar gyscos commented on May 27, 2024

The post is about having a front full-screen layer, and other layers behind it. All layers behind the front one will never be seen, and drawing them is wasted.

Having a front "invisible" layer that does not grab input is a separate issue like #558.

from cursive.

smallB007 avatar smallB007 commented on May 27, 2024

"The post is about having a front full-screen layer" - I don't think so. The OP complains about stackview calling draw/layout on all layers without checking if Layer/View is is visible or not. Anyway...
As a side note, I think it would be worth mentioning Cursive::add_screen in some tutorial (if it is mentioned in any I've missed it). My point is that in the tutorials this is not the suggested way to have full screen app. Instead add_fullscreen_layer (I believe) is suggested.

from cursive.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.