h5p / h5p-iframe-embed

h5p-iframe-embed

This H5P library makes it possible to embed "static" content displayed in an iFrame. The source may be internal or external:

• External: URI to external page to embed inside iFrame. The URI is editable using the H5P editor.
• Internal: this means at least the html-file is included in the H5P when beeing uploaded. Uploading html files or other resources is not supported by the H5P editor yet.

An example is found in the h5p-iframe-embed-example git repo

h5p-iframe-embed's Issues

Add option for having scrollbars

Having an option for enabling scrollbars would make it easier to embed more kinds of web applications. Ref. iframe will not scroll

H5P Iframe Embedder URL with space results in 404

Hello,

I have detected a problem with H5P Iframe Embedder working on Moodle. If I set a URL to a PDF that has a space in the filename and I store it in a moodle folder, H5P gives an error and does not show the content, resulting in 404 Not Found.

Steps to replicate it:

• Create a test course on demo.moodle.net (Moodle 4.0.4)
• In the course, create a folder resource and upload a pdf named "test file.pdf" (blank space important).
• Get the URL to the PDF by accessing the folder resource and right clicking on the file / copy link.
• Example link: https://sandbox.moodledemo.net/pluginfile.php/63/mod_folder/content/0/test%20flle.pdf?forcedownload=1 (note the space coded as %20).
• In the test course, create an H5P activity of type Iframe Embedder, set a title and in src indicate the URL: https://sandbox.moodledemo.net/pluginfile.php/63/mod_folder/content/0/test%20flle.pdf?forcedownload=1
• Save and access the activity.
• A 404 error will be displayed in DevTools (chrome. Firefox also fails).

In DevTools, if you analyze the URL that is being used to embed, you can find that it is encoding the %20 part of the URL as %2520. I think it encodes the original % itself as %25, resulting in %2520 and this is finally not recognized correctly and 404 is returned.

Actually, I detected the problem using the Interactive Book activity and in this one using Iframe Embedder, but in the end the problem seems to be in the latter.

This happens in Moodle 3.9.15, 3.11.8 and also in 4.0.4.

As otacke stated here: "The iframe embedder in fact encodes the URI that is provided."

We have to take into account that the teacher normally does not write the URL by hand, he copies it from another site and that URL should be correct, it has the spaces encoded and does not require modification.

In this case, so that the teacher did not have to edit the URL, what we suggested was to remove the spaces in the filename of the uploaded file in moodle and then copy the URL, however, it is still something "weird" that the teacher must do it this way.

I'm just reporting it in case it was feasible for the H5P component to stop altering the URL in this way, with the intention that the user would only have to copy and paste a URL without paying attention to character encoding issues.

Regards

H5P meta "Title" doesn't populate <iframe> title attribute

Hi,

Firstly, I apologize - i'm not experienced with H5P, and this could potentially be a PressBooks issue.

The H5P iFrame embedder doesn't appear to populate an iFrame's title attribute when using the PressBooks shortcode.

I notice it populates the title attribute when you click on "Embed", however, on a PressBooks page the title is missing from the rendered iFrame. For example: https://pressbooks.library.ryerson.ca/multivariatecalculus/chapter/unit-2-tangent-plane/

In the PressBooks admin page, I can see that all H5P objects have descriptive meta titles.

This issue seems to exist only for the H5P iframe embedder (so far). Other content types, like MC, Drag and drop, etc, - all seem to populate the title attribute correctly.

Thanks,

Adam

iframe autoplay

Hi! i love h5p :-)
question ... is possible to obtain autoplay function in iframe script?

Referrer on iOS

I'm using an iframe embedder to embed Vimeo (domain-privacy enabled) videos.

While it works fine on desktop, in iPhone Chrome / Safari, Vimeo unable to detect the domain and iframe embedder is not sending proper referrer.

Is that something that can be fixed here?

Moodle 3.8 + H5P Module.
Add column + iframe embedder + Quiz on one page.

Lack of accessible name for frames.

Not sure if this is supposed to be here or in the Interactive Video Repo but: For each or <iframe> element, provide an accessible name using ONE of the following methods. Good title attribute Better aria-label attribute Best aria-labelledby attribute.