hackoor83 / hyf-javascript3 Goto Github PK

Hi Sam(Hisham).
Your code looks clear and neat. I run your code on my VS. It works. But i get some error from eslint. There are something which you defined but you never used.Two of them are value of your functions. I am not sure but this may create a problem when you call the function. Another thing about some of your functions.
For example:

  addStar(star) {
    this.stars.push(star);
}

You did not use return in this function. Is this something ok? Can we use "this" as a return. Because "this" also returns inside an array which is inside the constructor. And You do not get any error even you call your function.(myMovie.addStar(firstActor);).

 addWriter(writer) {
    this.**stars**.push(new StaffMember('Alfonso Cuarón', 'writer', '28-11-1961'));
}

getWriters() {
    this.**stars**.writer;
}

This is the last thing which I don`t understand. Why did you use stars. As I know that we need to send the value inside the writer array which just defined in the constructor.

Thanks.

Hi Sam, here is my feedback on your homework.

1. Your addWriters() method take a parameter writer but you are not using it. Instead you have 'hard-coded' a StaffMember in the body of the method. If I call your method with another writer as its parameter, your method will just push another Alfsonse Cuarón. For addStar() you are doing it correctly, why the difference?
2. Similar thing for addMovie() in StaffMember.
3. The getAge() method of StaffMember is supposed to return an age (in years), not a birth date.
4. You correctly created a StaffMember object for the mainDirector but you do not use the myMovie1 movie you created with this director. Instead, you continue to use an earlier movie (myMovie) where the director is still just a string.
5. It would be nice if you would have added some code to add a couple of ratings and tested whether your getAverageRating() method returned the right result.
6. You added an index.html file in which you load your .js file, but you are not creating any HTML.
7. Your .eslintrc.json file should be in the root folder of your repo, not in week1 or week2. And you should alway open the root folder of your repo in VSCode, not any subfolder.