hackru / frontend Goto Github PK

Users found it confusing

Cookies

We need to look for a cookie called authdata in the browser. This cookie will contain JSON as a string:

{
    "token": "Their auth token",
    "valid_until": "The timestamp of the token expiry"
}

This cookie should be set on a non-MLH login. On page load, if the cookie yields a valid authentication,
the user's form should be rendered.

MLH

The login with MLH button need to exist. The following HTML should do the trick:

<button href=https://my.mlh.io/oauth/authorize?client_id=bab4ace712bb186d8866ff4776baf96b2c4e9c64d729fb7f88e87357e4badcba&redirect_uri=https://m7cwj1fy7c.execute-api.us-west-2.amazonaws.com/mlhitest/mlhcallback&response_type=code&scope=email+education+birthday">Login with MLH</button>

and then the page will eventually re-load with an authdata cookie which needs to be handled as above.

• Since we're going to launch with the new revamped react site, let's get it up on S3!

🍪

The auth data cookie is expired, awkwardly.

This leads to the issue Brandon referenced on the discord. Logging out and logging back in might fix it and is worth a try.

If you need the validate endpoint for this, let me know: I'll have to fix it up.

We need to make a splash page for HackRU Spring 2019. It's on the 9th of march at the College Ave Student center.

The site should be themed as it is and instead of a "go to dashboard", make the button "get on the mailing list" and link it to https://hackru1.typeform.com/to/OEtQEO

This should be on the prod bucket, but the script may not work if you want to avoid deploying the dashboard. We will also have to invalidate the sponsorship site and I'll comment here about that.

• Too much whitespace on landing: increase font / asset sizes?
• Duplicate 2018 copy on HackRU Fall 2018 / October 6, 7th 2018
• Pad out Saturday to make the schedules even
• If you hover the purple links, they turn yellow, which is unreadable on white <-- fixed to dark purple
• MLH banner should be black on the sponsorship page
• "Go to Dashboard" should read "Go To Registration"
• Move Login box above the other boxes
• Get rid of announcement / upcoming until day-of
• Get rid of "Want to Mentor" because it's not ready yet (VHX isn't ready) <-- same thing with volunteers
• Fix the date on the info panel (April 22nd -> October 6th)
• Hover rules on the sidebar on the left (shouldn't turn yellow)
• "GITHUB" should read "GITHUB USERNAME"
• Remove livestream until day-of
• Add optional ethnicity dropdown
• Change the wording of "waitlist" to be more clear to users <--- wait listed is pretty much the most concise form of this...I'm not sure what to do here, because putting registered, rejected, and waitlisted all under pending would kinda obfuscate things.
• Link snapchat in socials (maybe?) <--- did they get back to us?
• Mentor and volunteer links should not be on site when it's thin
• On mobile site the links and the header look wrong <-- hamburger menu was suggested I think

meet

We had too many blank responses last HackRU... so if they're empty, force the user to fill them.

We don't force users to update fields though, preferably.

Splash page has picture of rac instead of casc and the location correctly says casc.
I think we have casc pictures?

We need the following for day-of:

• QRs on logged in dashboard
• Slack announcements
• Calendar events view
• Map of the venue (coming soon from a logistics team near you)

Other note: registration will re-open on the day of. So may be have the frontend reflect that? (This isn't critical since we don't recommend registering on the day of either...)

Here is the view in redux-refactor:

If I click to change the school field for example, this happens (and forces the scroll bar to stay there):

Basically, the length of the list is forcing the scroll bar down, when it shouldn't. For comparison, here's what I see in master:

This is a cosmetic fix.

After the placeholder text that is already there would you be able to add placeholder text of like an example text field input so people follow a convention when entering travel? It might help lcs out after if everything was the same format? Right now it's very ambiguous the way the information would be entered. Maybe separate boxes for City and State? Right now it just seems ambiguous basically on the way the information is being inputed.

"Don't forget to source your .bashrc" This is a little hard to understand for newbies

We want to allow for directors to update the "wave" it is in registration (so the first n accepted hackers from wave k get an acceptence email welcoming them and lets them confirm attendence and those who said they were coming in wave k-1 are considered RSVPed).

I'll link the docs from the backend as I make them. This should be in the admin dashboard.

Remove from the view and remove from component functionality - and that includes removing the check for auth token from the url_parms in the UserForm and App.

Please work on this issue as a branch separate from master, mark it as 'view-alterations'

• Please ensure that the transportation options are displayed vertically.
• Also, when traveling info is updated, we'd like to make sure the user knows that the info is saved, probably by disabling the button and setting the label to "changes saved".
• Currently, the behavior does not trigger an update to LCS. Please change the behavior so it does, as most users won't be changing anything else once travel reimbursement is announced.
• Probably more of a CSS issue if anything, but the text field is also appearing off-center.

On the dashboard, under the 'Info' section, if you click on the College Ave Student Center link, the google maps that shows up is for the RAC (--Emily). Also, Also, open it in a new tab, not the same one. b/c we don't want a user to leave our site like that (--Dhruvil).

These should be different buttons so the users don't get confused

This color is rather hard to see, and on hover it becomes underlined- please have it match the behavior of Logout instead.

The library used react-select to make the autocompleting form is a bit broken: if a user puts in a custom value (when allowed) and then returns to the site, the custom value disappears.

from mobile chrome on LG G6 in new brunsqwick
https://cdn.discordapp.com/attachments/455471296046956554/475823761019371589/Screenshot_2018-08-05-20-32-46.png
screen is 1440px x 2880px
android 7

For the day of, this is the core of the dashboard last semester, without the login.

So it should include the same announcements, upcoming events and the common links.

It should be at hackru.org/live

• Move all CSS colors to use color variables and not be hard coded
• Prevent titles from cutting off
• For margin requests, use bootstrap classes instead of doing this by hand in custom css
• Fix issue with font squishing
• Fix issue with fb share metadata
• Colliding text on mobile phones in the About Us section.
• Fix Google Maps link pointing to RAC
• Instead of tiling background image, make it one single pane
• Add explicit scroll bars to things that can scroll
• In flash "Application has been saved" over "changes have been saved"
• "Your Info" should be "Your Application"
• "Pending" should be "Pending Review"
• "Save Changes to Application" and notify user of editable submission, instead of just a simple "save", per #47
• Fix Password overlaps on iPad, per #46
• Sponsorship Custom Package goes long off the page!
• Inconsistencies with flash messages. If I press save changes, I get a message saying thanks for registering but when I logout it says I have not filled in the required fields.

We made some changes to the packages: added “tech talk” to silver and added “mention in pre-event emails” for gold. https://docs.google.com/document/d/1OYV_bW2Vn_kjtkzKgfHM0KfxXm-zhTRWE2RjeouLuxU/edit?usp=sharing
Also, add some statistics: gender, diversity, age, and attendance.

When I click log out, with all fields filled, even the optional ones, it gives me the pop up notifying me I have missing fields.

There really should be a submit button instead of a "Save Changes", since it is very possibly the case that someone wants to save their changes but not necessarily submit the form. I think it would be a good idea to change the "Log out" to be Submit or something, as there is already a log out in the sidebar.

Once they've filled out some of the forms...sometimes they get error messages? Just make sure these are right.

List of all CSS differences noticed across browsers:

• The CSS with the background image on mobile needs to be addressed.
• Some header text runs off the page
• The footer should become a component and follow the same class rules as everything else.

Please investigate possible reasons for this.

You have full permission to bug Heman for code explanations if necessary, but it's self-explanatory.

The header color is dark green, maybe making it white like the text would be better?

• Put 'save unsaved changes' button in the side bar, which should be enabled whenever changes are made.
• Enable fill-in option on school select.
• Pop-up an error whenever birthdate is after October 6 2000 and user is not a Rutgers student, and then clear the birthdate.
• Switch 'Save Changes' and ' Logout'. (Enter causes a logout automatically?)
• Keep track if someone is not fully registered upon save. (didn't fill out required forms) Display this message on the dashboard page.
• Restrict resumes to txt, pdf, and img files.
• Hide Announcements, Upcoming, and Livestream. (Activate closer to HackRU).
• Add Ethnicity Question (mlh Link).
• Login/Registration box should be above Info box.
• We should have a sepearate instance of lcs for testing.

If the user has successfully applied, then there should be some indication their data is submitted and can be edited, but is currently received

Use a similar format as used in the travel form

(for crying out loud lol)

Options:
instagram
reddit
twitter
medium
twitch
youtube
plus a custom entry

The revamped site still needs login/sign up forms! Let's make it happen....

The splash page will redirect to /dashboard. Users should be able to login or sign up. On sign up they should have to fill out all the fields for lcs. On login, they should be prompted with their application status and given a button to edit their application.

• With the sidebar gone on the dashboard, we should have the HackRU logo included somewhere and a link back to the splash page.

The message cleanser, that removes emotes (:something:) and mentions (<garbage>) is broken. It just removes anything between colons and brackets, without insisting that they match.

This should be fixed... the interview submissions may help.

Something in the CSS is messed up and we need to revert and re-do the color changes using an older version

We need to fix the form to make it fit with the HackRU aesthetic. Feel free to discuss what that means.