hakaiinstitute / glintmaskgenerator Goto Github PK

Is your feature request related to a problem? Please describe.
GlintMaskGenerator does not work with Python 3.11

Describe the solution you'd like
Update the project to be able to support Python 3.11

Describe alternatives you've considered
I have been able to run GlintMaskGenerator successfully with Python 3.11, just by changing 2 np.float and 1 np.int references to float and int respectively.

Hello!

Just wanted to post this here. At the current state, GlintMaskTools does not support Python 3.11

However, as mentioned above, I was able to successfully run GlintMaskTools with Python 3.11 after some fairly minor changes.

Could this change be implemented? I can also give more information into what I changed within the current code if needed.

Hi team, thx for the quick reply last time. I also wanna quickly check with you if the intensity ratio algorithm is unavailable at the moment. I checked both GUI and python library, the RGBIntensityRatioMasker is not working. I tried to dig into the published article a bit but can't seem to find the difference of the threshold and intensity ration masker.

Hi there, I was trying to test the mask in python 3.8, installed the library with pip install with no issue in a conda env on MacOS.

However, the test script doesn't give the output masks and there is no error messages printed either.

Any help would appreciated.

My test script is

from glint_mask_generator import RGBThresholdMasker

masker = RGBThresholdMasker(img_dir="/path/to/my/images/", mask_dir="/path/to/store/masks/",thresholds=(0.9,0.9,0.9), pixel_buffer=3)
masker.process(max_workers=3, callback=print, err_callback=print)

I'm also attaching some test images below