hakandemirbilek / atom-auto-save-on-idle Goto Github PK

Hi! Thanks for maintaining the auto-save-on-idle package!

In Atom v1.19, we will release a major change to Atom's core text buffer data structure. As part of this change, we have made TextBuffer.save asynchronous; rather than blocking until the save is complete, it now immediately returns a Promise that resolves when the save is complete. Because of this, a few other Atom APIs that use save have similarly become async:

• Pane.close
• TextBuffer.save
• TextEditor.save
• Pane.saveItem
• Pane.saveItemAs
• Pane.saveActiveItem
• Pane.saveActiveItemAs
• Pane.saveItems
• Workspace.saveActivePaneItem
• Workspace.saveActivePaneItemAs

Effects on this package

We think this package could be impacted by this upgrade because it calls the changed methods in the following places:

• TextEditor.save
  • here
  • here

We found these calls using a regex search, so this list might be incomplete, and it might contain some false positives.

What to do about the change

It should be pretty easy to adjust your package code and/or tests to work with the new async behavior, and to simultaneously keep it working with older versions of Atom. Here are some examples of pull requests we opened on our bundled packages to cope with the change:

• atom/autocomplete-plus#852
• atom/whitespace#155
• atom/symbols-view#222
• atom/status-bar#193
• atom/tabs#448

Please let me know if you have any questions. I'd be happy to help!

The delay fixed at 1.5 sec is very small (and seems actually even less on my machine) and auto-save-on-idle' kicks in too quickly. This interacts poorly with tidy` which does a cleanup on save and deletes the empty line I just entered to start a new title. I setting to set it to whatever a user thinks is a good value would make the tool more usable!
thank you for considering!

I have two Macs, one Macbook Pro and one Imac. When running Atom on iMac, live-update happens even when typing in CSS but on Macbook Pro, the only time live-update, updates, is when I click and type in html. Please assist. Thanks!

The editor can act jumpy when typing at the end of a doc since the package whitespace ensures there's only 1 newline on save. It might be worth noting in the README that Ensure Single Trailing Newline and Remove Trailing Whitespace can be disabled in that package's settings to stop whitespace from being altered on save.

It would be really nice if you could add a feature to deactivate auto-save depending on where the file is located.