Comments (6)
I see no way to make that work on decoding. TLDR; There is not way to set the interface type (iface).
Basically, I would need something in there of the same type to be able to decode it without falling back to reflect Types and Values. If it is nil, or not of the right type, any attempt to set it would cause a seg fault or a type error. As you cannot create a new iface type, as it instantly becomes nil and an untyped nil at that, and there is no way to convert the decoded type to the iface type, I dont see how this would be doable.
This is not the same case in the encode side, as you already have the type, so none of this type conversion stuff applies here.
This means we can only really support efaces, unless you see another way I am not seeing.
from avro.
I have been trying to step through the code and figure out how to make it work and I cannot see how to make it work either. Thanks for the quick response. Ill close.
from avro.
I literally spend 3 hours to try get the initial interface type to accept a new pointer, but to no avail.
from avro.
There isn't a single go avro library that makes it work. A lot of them won't even marshal union types.
from avro.
Sorry but I don't understand why decoder couldn't be made to work. The decoder could treat interface receivers in this way:
- Inspect the data and figure out the name of the concrete avro type
- Look up the registered Go type under that name. If not found, fallback to the old implementation
- Check if the registered Go type fulfill the given interface, if not return an error
- Check if the receiver is of the registered type, if not return an error
- Decode the data into the receiver and profit
Unless there's something else I'm not understanding.
from avro.
Interface types (iface) are not createable in Go, you are only able to covert a concrete into an iface type. In reflect this possible, but using rtypes and unsafe pointers, there is no mechanism to do this.
Getting the concrete is not an issue, but as the interface is nil, there is no way to get the value out again.
from avro.
Related Issues (20)
- Support TextMarshaler/TextUnmarshaler for map keys HOT 2
- need an method generate schema from struct HOT 7
- Bug for tree typed schema HOT 2
- [BUG] array schema cannot be correctly parsed HOT 4
- Local timestamp logical types HOT 1
- Add support for Zstandard compression
- Enum schema evolution for missing value in reader schema but with default HOT 3
- Question about max byte slice HOT 6
- Performance degradation in v2.19.0 HOT 4
- Wrong decoding of nested map HOT 1
- Infinite loop parsing recursive array type HOT 1
- "unknown union type long" error HOT 2
- Support nested array of record HOT 3
- Bug with encoding union + fixed + decimal HOT 6
- Problem with empty slices vs nil. HOT 8
- Decode Array - Panic: Allocation size out of range Error HOT 1
- I struggle to have more than one "registered" type in the same field of a schema HOT 9
- Reasoning behind swallowing EOF errors? HOT 2
- Decoding of map[string]any behavior changed HOT 3
- [avrogen] tags - having omitEmpty in the json generated object HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from avro.