hanakla / inlineattachment

Easily paste and upload files/images in plain textareas

I AM Hanakla❗

Frontend engineer, Illustrator, DJ, Music Remixer lives on Japan.
Creator of Flux framework Fleur and Web-tech based VFX app Delir

Skills⚡:
TypeScript / JavaScript / React / CSS / Electron / Next.js / Node.js / Ruby on Rails / PHP / 日本語
And beginner of ギャル

Supervision: fleur-js, delirvfx

Contact

🌐 Web: https://hanak.la
🐦 Twitter: https://twitter.com/hanak1a_
🔠 Zenn: https://zenn.dev/hanak1a
⚒️ Qiita: https://qiita.com/hanakla
🎨 pixiv: https://pixiv.me/hanak1a
🎶 SoundCloud: https://soundcloud.com/hanakla
🔊 MixCloud: https://www.mixcloud.com/hanakla

inlineattachment's Issues

Support Async hooks

Docs

Hi!

Could you give a basic explanation on how to use this package? I understand you've made many changes to the original package and I'd like to know how to use the new version. Thanks.

Wrong typings

with TypeScript 2.8.3, found some type errors

ERROR in /path/to/project/node_modules/@ragg/inline-attachment/src/inline-attachment.ts(107,9):
TS2722: Cannot invoke an object which is possibly 'undefined'.

ERROR in /path/to/project/node_modules/@ragg/inline-attachment/src/inline-attachment.ts(139,9):
TS2532: Object is possibly 'undefined'.

ERROR in /path/to/project/node_modules/@ragg/inline-attachment/src/inline-attachment.ts(139,9):
TS2684: The 'this' context of type '(() => boolean) | undefined' is not assignable to method's 'this' of type 'Function'.
  Type 'undefined' is not assignable to type 'Function'.

ERROR in /path/to/project/node_modules/@ragg/inline-attachment/src/inline-attachment.ts(152,9):
TS2532: Object is possibly 'undefined'.

ERROR in /path/to/project/node_modules/@ragg/inline-attachment/src/inline-attachment.ts(152,9):
TS2684: The 'this' context of type '(() => void) | undefined' is not assignable to method's 'this' of type 'Function'.
  Type 'undefined' is not assignable to type 'Function'.

ERROR in /path/to/project/node_modules/@ragg/inline-attachment/src/inline-attachment.ts(166,9):
TS2532: Object is possibly 'undefined'.

ERROR in /path/to/project/node_modules/@ragg/inline-attachment/src/inline-attachment.ts(166,9):
TS2684: The 'this' context of type '(() => boolean) | undefined' is not assignable to method's 'this' of type 'Function'.
  Type 'undefined' is not assignable to type 'Function'.

ERROR in /path/to/project/node_modules/@ragg/inline-attachment/src/inline-attachment.ts(180,9):
TS2532: Object is possibly 'undefined'.

ERROR in /path/to/project/node_modules/@ragg/inline-attachment/src/inline-attachment.ts(180,9):
TS2684: The 'this' context of type '(() => boolean) | undefined' is not assignable to method's 'this' of type 'Function'.
  Type 'undefined' is not assignable to type 'Function'.

Pass a customized InlineAttachment instance into editor-specific classes

If the uploadFile method has to be changed, a subclass of InlineAttachment overriding the uploadFile method will be required. However, that subclass cannot be passed into an editor-specific instance, such as InlineAttachment.CodeMirror4, because there is no constructor parameter and no setter to change the private inlineAttachment.

I think the type of the option parameter of the constructor may be changed to accept () => InlineAttachment | Partial<InlineAttachmentSettings>.