handyman5 / poodledo Goto Github PK

I'd like to include this as a submodule in another Github project. I'd like to include it as a package. It will need the init.py file created.

http://docs.python.org/tutorial/modules.html

When trying to delete tasks or notebooks, apiclient.py fails to assemble the correct API calls. This patch fixes the issue for me:

diff --git a/apiclient.py b/apiclient.py
index 6df234f..4ecc2bd 100755
--- a/apiclient.py
+++ b/apiclient.py
@@ -595,7 +595,7 @@ class ApiClient(object):
         '''
         id_ = self.getNotebook(label).id
         self._notebooks_cache = None
-        return self._call(key=key, kind='notebooks', action='delete', id_=id_).text
+        return self._call(key=key, kind='notebooks', action='delete', notebooks=[id_]).text

     @check_api_key
     def editNotebook(self, label, key=None, **kwargs):
@@ -674,7 +674,7 @@ class ApiClient(object):
         '''
         id_ = self.getTask(label).id
         self._tasks_cache = None
-        return self._call(key=key, kind='tasks', action='delete', id_=id_).text
+        return self._call(key=key, kind='tasks', action='delete', tasks=[id_]).text

     @check_api_key
     def editTask(self, label, key=None, **kwargs):

Coming into this module cold, a couple points.

First, if you "python setup.py install" I think the example is actually "import poodledo.apiclient", right?

Second, I couldn't find any info on what should be in tdclirc or what its format is - ConfigParser format? What sections? What fields? Dug it out of cli.py but you might want to document it.

Keep up the good work!

Wou/d a patch to add a setup.py file and add poodledo to the python package index be ok? I want to eventually add a package I'm working on and list it as a dependency or an optional dependency, not sure yet.

apiclient.py imports dumps of json module.

But, in Python 2.5, json module is not built-in.
Should I use simplejson?

Whenever, I launch tdcli, I am getting extremely slow startups, on the order of 30 seconds, even after I have authenticated completely. I am not sure what is causing the delay, but I have tried looking at python -v tdcli it it holds for most of the time after showing import StringIO.

When I import StringIO, or any of the other import commands I see when viewing the verbose log, I have no delay.

Is this in the pipeline at all? I'm starting a new Toodledo project and I definitely want to use OAuth2, but I want to avoid reinventing the wheel, if I can.