haroldputman / bingo-cards Goto Github PK

There is no favicon or an icon for when you add this to your homescreen on iPhone or android.

It would be cool to be able to create a Gist in GitHub and load the tropes from there. It's a free and easy way to expand the game without building new code.

It would make sense to deploy out of GitHub rather than push from a local system. So find a free way to do this, and implement it.

I should add a page that tells that I am using Google Analytics. And that I don't capture any PII. I won't tell anyone that you held back tears during that last scene.

Track with Analytics when a Bingo is acheived. This needs to somehow catch the first time the bingo is detected.
I guess it will be to save bingos in a global and then check the newly detected bingos against the global, and see what is new. Only alert when there is a new one. Also maybe flash the header or popup some rewarding animation.

Since my userbase is so small it might be misleading if dev testing is sending data to Google Analytics. See if there is a way to disable analytics if you are running from local. Maybe this is something added to express since in production we are only serving static files from google.

This is not a user-facing issue. When originally writing this I called the things in the squares "clues" for lack of a better name. I think prompts is more better. Change all references in the code. This would also change the URL parameter from cluefile= to prompts=.

Might also want to reconsider whether the prompt file is a load time or a build time parameter. Realistically you'd need a code change to build bingo for another domain. Unless you could pull the json from another source by specifying a URL instead of a filename.

Kids won't get much of the sarcasm in the current film-tropes, but might still enjoy playing with simpler prompts. More like the game you used to play on car trips? "Red bow", "Santa Hat", "Kissing (yuck!)". Should be able to switch to kids mode on iPad or for printing.

Of course...

Because it is 2019.

Is there a way to detect from Mobile device whether the user has system-wide dark mode selected?

In any case we should allow them to choose darkmode somehow. and store their choice in a cookie or local storage.

Maybe this is already the case since there is no backend powering this.
Maybe it means we store the json file locally and reset the board without hitting the server.
But it would be an interesting exercise to understand how to make this an official PWA.

This is needed to facilitate

• #6 Sharing Button
• #11 Feedback Link
• #16 Dark mode
• #25 Kids mode
• #26 Privacy Page

We've had trouble lining up the header with B-I-N-G-O. But why waste screen real estate on this? Everyone knows it is a bingo card. The letters are not needed for the game to work or to be understood.

I was thinking about how a bingo card might look in lynx. Functionally, it is really just 25 check boxes right? Why not have the markup reflect that and style it to look like a grid.
This might open up some other tricks like saving games and checking for bingos

Since this started as a JSFiddle, I didn't bother setting up eslint, prettier, editorconfig, etc... Add those standard things with reasonable settings. All PR's should get linted during build for sure.

In a vanilla JS way, add buttons to share this on facebook, Twitter and wherever else the kids hang out these days.

Because I work for a printer company, and we hope that people still print. And because sometimes you might want to do this offline for a watch party at the Senior Center.

While I want to keep the UI simple, there might be a reason to offer a feedback link so people can report issues, or offer suggestions.

When running as PWA in Airplaned mode:

• New Game button does not work.
• daub2.jpg is not cached so the bingo daubs disappear.

When the bingo card loads there is a p point where stiles are not ready.

When you get bingo... Nothing happens.
Need to detect when a bingo is marked. Keep it simple (only horizontal row, veritcal column or either diagonal).

The idea is to prevent deploying unpublished code from your local.
There is a git command that will return nonzero exit code if the working copy is dirty.

A much better approach would be to add something to Git so it deploys using so CI/CD system when merging to master. So actually forget this one.

Both on iOS and Android if you close and restart the app after installing to home screen, it does not remember the board