harunou / react-mobx-clean-architecture

An example React+Mobx application with Clean Architecture

curl -L www.harunou.in/stall | bash -s -- .harunou

react-mobx-clean-architecture's Issues

Just Store?

react-mobx-clean-architecture/src/stores/helpers/stores.helpers.ts

Line 60 in 98a5219

export abstract class RootStore<S, P> {

TestRootProvider move to testing tools

Unify file names

Tests from App.store.spec should go to stores.helpers.ts

UseState is required

react-mobx-clean-architecture/src/stores/helpers/context/context.helpers.ts

Line 33 in fba36a1

const controller = new ControllerConstructor(store);

Test sequence of async action execution

Restore node env?

react-mobx-clean-architecture/jest.config.js

Line 143 in e0d0793

// testEnvironment: 'node',

Align builders and effect, usecase and selector names

allow usage of feature stores in feature modules

Check if undefined is needed

react-mobx-clean-architecture/src/stores/app/app.types.ts

Line 12 in 98a5219

export type AppUseCaseParams<P = undefined> = UseCaseMakeParams<

add useAdapter hook

const {controller, presenter} = useAdapter(FeatureController, FeaturePresenter)

Add ui store

DomainStore      UiStore
     |____________|
            |
         AppStore        PersistenceStore
            |___________________|
                     |
                 RootStore 

Make count computed

react-mobx-clean-architecture/src/modules/counter/adapter/counter.presenter.ts

Line 9 in 4613e6a

selectMultiplyCountOn_10: computed

Pass arguments from event to usecase

Avoid using default

Interactors shold receive object in make

Add DI engine to automatically resole dependencies

Split into 2 functions

react-mobx-clean-architecture/src/stores/helpers/context/context.helpers.ts

Line 9 in 4613e6a

const RootStoreContext = createContext<S | undefined>(undefined);

Add onInit and onDestroy hooks to the controller

Make flow hidden, but add static cancel

react-mobx-clean-architecture/src/feature/store/effects/save-count-success.effect.ts

Line 7 in 98a5219

static flow: CancellablePromise<number>;

Split useCase and Selector types

Effects should have aceess to models

Counter.init is private

react-mobx-clean-architecture/src/stores/counter/counter.store.ts

Line 22 in 308a3ec

init(state: CounterState): void {

Add example of entity repository usage

Split builder and builder with props?

Multiply->MultiplyCount

Extends AppState?

react-mobx-clean-architecture/src/stores/app/app.types.ts

Line 7 in 308a3ec

export interface AppModel {

Add BankAccountStore

interface BankAccount {
  increase(amount: number): void
  decrease(amount: number): void
  saldo: number
}

Make Builder.withParams method generic

Feature.flow->name.effect

Rename effect method to execute? Make aligned with command pattern ?

react-mobx-clean-architecture/src/feature/store/effects/save-count-success.effect.ts

Line 14 in 98a5219

save(count: number): CancellablePromise<number> {

Remove all flows

react-mobx-clean-architecture/src/feature/store/usecases/increase-value-and-save-pessimistic.usecase.ts

Line 26 in 98a5219

private flow: SaveCountSuccessEffect,

S extends object

react-mobx-clean-architecture/src/stores/helpers/context/context.helpers.ts

Line 5 in 4613e6a

export const makeContext = <S>(): {

Add modules directory

react-mobx-clean-architecture/jest.config.js

Line 87 in e0d0793

'^@testing-tools$': '<rootDir>/src/testing-tools.ts'

Make Selector type generic