harvestprofit / harvest-profit-pdf Goto Github PK

We should enable source maps for this. We already use webpack, so why not?

We could probably use an example implementation for this repo

You should use a basic header with a HP footer or the opposite. Just needs to be added to the exports.

@jarydkrish I'd create a PR but I do not have access to write to this repo apparently.

So the reason we stayed on PDFKit was that we had a bunch of stuff all built already and because we needed tables that would automatically insert the table header onto the next page by default which was hard to come by. But after taking a second look at some of this, I think it is possible to switch to jsPDF. The main thing this does for us is file size see the last comment here. PDFkit is HUGE (like 2mb) were jsPDF is closer to 50kbs (or something like that). Also, there is this plugin which allows for table headers to show up on every page. Plus I think it has more styling stuff. We would have to do a bit of work to get some of the same layout stuff built back again like page numbers and the logo but I think that would be pretty easy.

As a side note, anyone want to try to build a "react-ish" way of generating PDFs? I'm thinking the render function returns a JSON object which can be put through a PDF generator engine. That'd be cool....

We could use more docs. And more linting. And more coffee ☕️