hashrock / deno-opn Goto Github PK

We might not do much testing on GitHub Actions(Linux CLI), but at least we can see if the deno execution passes.

There is no __dirname in Deno, I can't execute xdg-open.

Related:

denoland/deno#1286

The original opn can determine that it is itself running from the WSL.

Deno can't do that because of:

• "platform" in WSL returns just { arch: "x64", os: "linux" }
• there is no os.release().

if i start the most simple example utilizing your code by deno 0.35.0 on debian linux;

import { opn } from 'https://denopkg.com/hashrock/deno-opn/opn.ts';
opn('https://example.com');

i'll only get this error reports:

error TS2339: Property 'platform' does not exist on type 'typeof Deno'.

► https://raw.githubusercontent.com/hashrock/deno-opn/master/opn.ts:1:14

1 const { run, platform } = Deno;
               ~~~~~~~~

error TS2532: Object is possibly 'undefined'.

► https://raw.githubusercontent.com/hashrock/deno-opn/master/opn.ts:34:19

34   const appArgs = optsWithDefault.app.slice(1);
                     ~~~~~~~~~~~~~~~~~~~

error TS2532: Object is possibly 'undefined'.

► https://raw.githubusercontent.com/hashrock/deno-opn/master/opn.ts:35:39

35   const openApp: string | undefined = optsWithDefault.app[0];
                                         ~~~~~~~~~~~~~~~~~~~


Found 3 errors.

I saw that you use GitHub Pages now,
unfortunately there are some problems
with markdown as you might have noticed.

https://hashrock.github.io/deno-opn/

How about moving the documentation that
is present in the README and the example
from the /Documentation/ folder into
a dedicated branch called Documentation
with the root as it's entry point?

to preparing for Deno API changes.

use deno fmt to conform to deno convention.