hassankhan / syngr Goto Github PK

Someone posted on Reddit or HN about trim() not working correctly, need to add more test cases then see what happens.

Hey, nice project. I had started something very similar some time ago but I realized that the oop approach doesn't work quite well as you can't force other to use your classes. Then I decided to go functional style, where you receive "kind of" unexpected input but produce predictable output; the result is a very simple and small api that plays nice with others. You can take a look at the code at https://github.com/eridal/prelude

I'd really like to join forces :)

Issue tracker for port to Zephir. Overall it shouldn't be insanely difficult, should just need to enforce static types wherever possible.

The biggest problem I see with this library is that everything is mutable. Just to illustrate this:

function getInitial(String $name) {
    return $name->substring(0, 1);
}

$name = new String('Igor the Terrible');
$initial = getInitial($name);

var_dump($name);
//= string(1) "I"
// WTF!

You should always return a new instance of everything. You should never be able to change an existing value.