hatharry / emby.serverupdater Goto Github PK

I just installed the script and when I ran the task it was erroring out. I went and manually ran the task to debug and see where the problem was and I found this:

[DBG]: PS C:\WINDOWS\system32>> $this.assetUrl
https://github.com/MediaBrowser/Emby/releases/download/3.2.70.0/embyserver-win-x64-3.2.70.0.7z
https://github.com/MediaBrowser/Emby/releases/download/3.2.70.0/embyserver-windows-x64-3.2.70.0.7z

I manually modified line 68 to read
Invoke-WebRequest $this.assetUrl[0] -OutFile "$($this.location)\updates\MBserver.zip" -UseBasicParsing

this resolved the issue but I am not sure this is truly the proper way to handle the situation. I figured I'd let you know

After running, my Emby server was updated to the latest beta version. Is there a way to get back to the stable/release version? Like maybe a flag or something at run-time (-release, or -stable)?

Awesome script btw saves me a bunch of time so thank you.

Its possible I just dont know what I am doing, but I get:

At C:\Users\mcfal\Downloads\Emby.ServerUpdater-master\Emby.ServerUpdater-master\EmbyServiceUpdater.ps1:2 char:13

• #requires –runasadministrator

•         ~~~~~~~~~~~~~~~~~~~
  

The string is missing the terminator: ".
At C:\Users\mcfal\Downloads\Emby.ServerUpdater-master\Emby.ServerUpdater-master\EmbyServiceUpdater.ps1:2 char:11

• #requires –runasadministrator

•       ~~~~~~~~~~~~~~~~~~~~~
  

Cannot process the #requires statement because it is not in the correct format.
The #requires statement must be in one of the following formats:
"#requires -shellid "
"#requires -version <major.minor>"
"#requires -psedition "
"#requires -pssnapin [-version <major.minor>]"
"#requires -modules "
"#requires -runasadministrator"
+ CategoryInfo : ParserError: (:) [], ParseException
+ FullyQualifiedErrorId : TerminatorExpectedAtEndOfString

.\EmbyServiceUpdater.ps1 -ApiKey "****" -ServerUrl "http://192.168.111.11:8096" -update

This is what i get when i run the command (if you can see the picture). Am I running it wrong? I don't think the ReadMe is very clear sorry for being a bother about it. I'm not sure what [-InstallTask] and the other options actually mean. Please help me.

I am having 2 issues with the script.

1. Since I have an Emby server on the Beta Channel, when I change line 36 to equal $true, when I update the script it clears out this customization and I have to remember to update that as well. SInce I have a schedule task that updates the script, these changes are lost each time the script is updated
2. Line 62 is not comparing versions correctly. Currently $this.release.tag_name = 4.1.0.10 and $this.localVersion = 4.1.0.9 so the comparison of $this.release.tag_name -gt $this.localversion is returning false instead of true. Since $this.localversion is already of the type [system.version], If I cast $this.release.tag_name to the same type it works as expected. my Modified line looks like this.
   if ([version]$this.release.tag_name -gt $this.localVersion) {

The location property will return an array of strings instead of a single string if multiple processes for Emby are present in the system.

Suggestion to change to:

 $embyProc = (Get-Process embyserver)
 if ($embyProc.Length -ne 1)
 {
    Write-Error "Multiple instances of emby running detected"
 }
 $this.location = (Get-Item $embyProc.Path).Directory.Parent.FullName