GithubHelp home page GithubHelp logo

botvac-wifi's People

Contributors

12458 avatar benklop avatar hawtdogflvrwtr avatar jeroenterheerdt avatar sstadlberger avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

botvac-wifi's Issues

insecure method for receiving commands

Hello, I'm a little uncomfortable with the device contacting http://www.neatoscheduler.com/api/actionPull.php over http, and then running arbitrary commands on the neato as received. It looks like the esp8266 IS capable of using https, at least as a client: https://github.com/esp8266/Arduino/blob/master/doc/esp8266wifi/client-secure-examples.rst, and then the firmware could check the certificate fingerprint against the known fingerprint for the server, so it would be impossible for someone to, for example, spoof DNS and end up with a complete map of my home.

I don't think it's probably feasible to implement the server portion as https, but since the only communication outside my home network is done in client mode, I think this would provide sufficient security.

Compile in the Arduino 1.8.13 environment

I really like this project after trial.

Reference sstadlberger/botvac-wifi project update

  1. ESP8266WebServer server = ESP8266WebServer(80);
    Replace with:
    ESP8266WebServer server (80);
  2. removed mDNS

Mention a scheme that is immature under the existing framework - About solving the problem that the sweeping robot cannot sleep.When the sweeping robot is parked on the charging base and the battery discharge current is greater than 10 mA, it is forced to sleep by the command (setsystemmod hibernate).
But this will prevent the sweeping robot from responding to Action commands on the web management page.Moreover, its battery will be over-discharged and the working time will be greatly shortened the next time it works (because its power management chip will think that the battery is not depleted and cannot be recharged on time. In fact, Ni-MH batteries have self-discharge problems).

Looking forward to a better solution or the author to modify the entire framework.

void setBotHibernate() {
Serial.setTimeout(500);
Serial.println("GetCharger");
String batteryInfoTemp = Serial.readStringUntil(0x1A);
String checkArray[2] = {"ChargingEnabled", "Discharge_mAH"};
String itemValue[2] = {"", ""};
for (int i = 0; i < 2; i++){
int currentItemIndex = batteryInfoTemp.indexOf(checkArray[i]);
if (currentItemIndex > -1){
int commaIndex = batteryInfoTemp.indexOf(',',currentItemIndex);
int currentItemEnd = batteryInfoTemp.indexOf('\n',currentItemIndex);
itemValue[i] = batteryInfoTemp.substring(commaIndex+1,currentItemEnd-1);
itemValue[i].trim();
}
}
if ( itemValue[0] == "1" && itemValue[1].toInt() > 10 ){
Serial.println("Testmod on");
Serial.println("Setsystemmod hibernate");
Serial.println("Testmod off");
}
}

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.