hedius / e4gladkats

More advanced and maintained version of the PRoCon Battlefield Admin Plugin AdKats.

Hi there 👋

---

e4gladkats's Issues

Perks do not work with VSM slots

I use VSM to manage my VIPs. AdKats offers the option to feed Reserved Slots to VSM, but only when a new resveredSlot is added.

However, the code ignores slots from perks...

Announce Online Voice Players

Feature request from stalklim,

1. If there are players online in teamspeak or discord,
2. Then send a spam message announcing to the players that there are x players in voice.

E.g.: Looking for mates to play with? There are x players in voice at our teamspeak/discord.

Maybe also mention the name?

Not sure if I will implement this. Mostly, busy with WoW classic atm :)

Workflow:

1. Settings: enable this, announce player # names, announcement Interval., teamspeak msg, discord msg.
2. If enabled -> start a thread for this
3. Disabled -> end the thread
4. Thread sleeps x seconds and then checks the member lists.
5. Both the discord and teamspeak integration are present as public accessible objects afaik. So this should be possible.

KPM check issues invalid Bans

The KPM aimbot checker bans heli players often. We do not want this. fix this

Custom Kick Count for temp/perma mutes

Privilege Escalation in BBR scheme

I use the AdKats DB scheme for my battle bit backend. (Not OSS atm. Soon tm :) )

Problem here is that a new column "SteamID64" has been introduced in tbl_playerdata and EA/PB GUID are set to null for BBR players.

AdKats performs permission lookups by player_id AND by EAGUID. This is bad. Terrible.

BBR users have null here. And AdKats also performs lookups for soldiers of other games / unsupported games if they are assigned to an AdKats user. This results in lookups for the GUID null and matches the adkats_user with the lowest user_id.

Furthermore, this results in all bf4 soldiers of users with at least 1 assigned BBR soldier receiving the permissions of the user with the lowest ID. (Since their BBR soldier with GUID null matches 1st.)

We only should search by player_id.

Add move protection list

Admins must not move VIPs on our servers.

This is not enforced at the moment.

Introduce a new list to block certain roles from being moved.

Empty Role IDs arrays cause empty mention string in reports

Perma Mute

Implement permanent mutes into the AdKats & BFACP system.

Add player watchlist support

Quite easy:

• New list "watchlist"
• Setting: Enable Discord notification for joining players on watchlist
• Setting: Announce leaves on discord
• Setting for Discord Webhook / Webhook will be used for notifications (URL)
• Setting Array: Role IDs to mention.
• Update discord module for sending a join and leave embed.
• 2 New commands (add, remove)
• Update the OnJoin thread -> send discord notification if in list and enabled
• InGame Notifications

Mass bans by Anti Cheat during switch to winter time

Timeout /move if a move is not possible.

Admins use /move to balance teams manually if needed. Problem: The move happens usually too late or near to round end if teams are full.

Fix: The move command should auto dequeue after 5 minutes.

Plugin starts stats logging after a round start happened.

We restart our procon layers at least once per day. However, we have then data gaps in tbl_extendedroundstats until a round start happens. Looks terrible in our Grafana Panels and data analysis.

-> Always log data.

Warn perma muted players on join / first spawn with a tell