hedonhermdev / django-on-docker Goto Github PK

Firstly, thanks for the great tutorial.

While reading the blog and code here, I found some inconsistence in django-on-docker/deployment-project/djangoproject/Dockerfile , and that might be some typos.

At the very first code version in your blog, the env args are

# These two environment variables prevent __pycache__/ files.
ENV PYTHONUNBUFFERED 1
ENV PYTHONDONTWRITEBYTECODE 1

, but in the end of the blog and in this repo, the env args are

ENV PYTHONBUFFERED 1
ENV PYTHONWRITEBYTECODE 1

, and only the first form can be found in the python document.

Hi thanks for putting out this solid example of how to deploy Django with Docker.

Something stuck out to me as unneeded and exposing a potential security issue for someone in the future.

    ports:
      - 5432:5432

This line will open the psql daemon to the host system, which is not necessary as the postgres image will expose that port, making it available to other containers on the same network. I've tested at it works fine without that line. Just a quick suggestion that might save someone a headache in the future.