stage2.go and stage2.php should behave the same? about henkaku

[psychowood]

Fyi, the Go implementation is working correctly. PHP was served from a windows machine, if it matters.

[yifanlu]

I think they should be the same. Does PHP work? If not, your PHP might be misconfigured.

[pythonicca]

I noticed this as well. I'm not a PHP guru but in my environment PHP had a hard integer limit which it silently returned when the value was exceeded. (there's no outward indication that your values have been replaced and stage2.php doesn't explicitly check for this).

(Example) if stage2.php is passed these parameters:

a1=89f02000&a2=81b009a0&a3=e000dd00&a4=811c0cc0&&a5=e0607c80&a6=e01302b0&a7=e0047bf0&

a1-a7 values are all returned as 2147483647 and the binary created won't function the way it was intended.

The culprit in stage2.php is:

$args[$i] = intval($_GET["a$i"], 16);

An option might be to convert it to a string instead but that might require some changes elsewhere as well..

function hex2dec($hex)
{
    $dec = 0;
    $len = strlen($hex);
    for ($i = 1; $i <= $len; $i++) {
        $dec = bcadd($dec, bcmul(strval(hexdec($hex[$i - 1])), bcpow('16', strval($len - $i))));
    }
    return $dec;
}

$args[$i] = hex2dec($_GET["a$i"]);

[xyzz]

can we just remove the PHP version? the Go one is very simple to run

[psychowood]

Especially with a (shameless hint :) ) java version available.

[pythonicca]

If we could get a python implementation of stage2 it would be even simpler (with Python being the sole requirement). If whoever wrote preprocess.py and write_pkg_url.py could also write a working stage2.py (that outputs the same binary as the go version) I can contribute the code I've already written that ties everything together.

[yifanlu]

This whole package is for hackers and tinkerers, so if you have a suggestion, make it and send a pull request :)

[xyzz]

You don't need these files anymore, since we just require static webserver now.