GithubHelp home page GithubHelp logo

handpick's People

Contributors

henryruhs avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

handpick's Issues

Yarn lock not being respected

Hi,

Is it possible to respect the versions in the yarn.lock file?

Also is it possible to pass the --offline parameter?

Thanks!
Ash

Respect package.json format

At the moment the package.json is not respectful handled and reformated during handpick's processing as of fs.writeFile limitations for JSON files.

Before

{
	"lintDependencies":
	{
		"eslint": "1.0.0",
		"eslint-config-redaxmedia": "1.3.0"
	}
}

After

{
	"lintDependencies": {
		"eslint": "1.0.0",
		"eslint-config-redaxmedia": "1.3.0"
	}
}

Warning if lockfiles are ignored

There should be a warning if a package-lock.json, yarn.lockor pnpm-lock.yaml are found and the related managerObject contains a --no-lockfile command.

Potential version 2 for option file:

{
	"version": 2,
	"managerObject":
	{
		"npm":
		{
			"commandArray"
		  	[
				"install",
				"--no-package-lock"
			],
			lockFile: "package-lock.json"
		}
		...
	}
}

New version is causing a crash on our existing build

We have a Dockerfile building an image for testing and it is failing now that it is installing [email protected]. Everything was working fine when it was using 3.2.1.

Here is the error that gets generated when we execute the handpick command

(node:8) UnhandledPromiseRejectionWarning: TypeError: this.stream.clearLine is not a function
    at SpinnerClass.stop (file:///usr/local/lib/node_modules/handpick/src/spinner.class.js:40:21)
    at SpinnerClass.error (file:///usr/local/lib/node_modules/handpick/src/spinner.class.js:36:41)
    at file:///usr/local/lib/node_modules/handpick/src/core.class.js:91:48
(Use `node --trace-warnings ...` to show where the warning was created)
(node:8) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:8) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

It appears to be due to the new spinner section in the .handpick configuration file. Apparently the new software does not handle it if the .handpick file is not updated to contain the information. Not exactly sure what the spinner is supposed to be doing. Can you add some documentation as to what is required for this and what it will provide as a result?

Issue with hard linked repositories

The following pattern is not working as semver returned null:

hruhs@mole:~/PhpstormProjects/redaxscript-template$ handpick 
✖ TypeError: Cannot read property 'version' of null
{
	"devDependencies":
	{
		"redaxscript-flaticon": "https://github.com/redaxscript/redaxscript-flaticon.git"
	}
}

Idea: handpick update command

Hi,

thanks for providing handpick. 🙏

Recently I updated all packages of a customer's project.
I forgot about updating the version numbers of handpick's package-declarations.

It would be nice to have a command like handpick update that automatically updates all version numbers according to the packages defined in dependencies/devDependencies.

Bug: Cannot read properties of undefined (reading 'toUpperCase')

Getting the following error without any change to my codes, maybe related to the 2hours ago publish:

file:///Users/user/_work/_tool/node/16.18.0/x64/lib/node_modules/handpick/cli.js:66
            range.toUpperCase(),
                  ^

TypeError: Cannot read properties of undefined (reading 'toUpperCase')
    at Core.startWording (file:///Users/user/_work/_tool/node/16.18.0/x64/lib/node_modules/handpick/cli.js:66:19)
    at Core.init (file:///Users/user/_work/_tool/node/16.18.0/x64/lib/node_modules/handpick/cli.js:24:33)
    at Core.cli (file:///Users/user/_work/_tool/node/16.18.0/x64/lib/node_modules/handpick/cli.js:60:14)
    at file:///Users/user/_work/_tool/node/16.18.0/x64/lib/node_modules/handpick/cli.js:394:6
    at ModuleJob.run (node:internal/modules/esm/module_job:193:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:526:24)
    at async loadESM (node:internal/process/esm_loader:91:5)
    at async handleMainPromise (node:internal/modules/run_main:65:12)
Error: Process completed with exit code 1.

New Spinner causes significant output to CI/CD Pipeline Jobs with gitlab

When the gitlab CI/CD Pipeline runs to build our images using handpick the spinner information continually gets appended and not replaced.

Small snippet:

 ---> Running in 8017071ba57e
�[?25l�[2K�[1G⠋ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠙ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠹ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠸ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠼ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠴ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠦ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠧ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠇ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠏ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠋ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠙ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠹ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠸ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠼ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠴ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠦ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠧ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠇ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠏ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠋ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠙ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠹ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠸ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠼ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠴ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠦ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠧ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠇ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠏ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠋ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠙ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠹ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠸ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠼ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠴ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠦ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠧ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠇ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠏ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠋ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠙ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠹ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠸ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠼ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠴ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠦ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠧ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠇ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠏ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠋ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠙ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠹ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠸ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠼ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠴ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠦ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠧ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠇ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠏ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠋ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠙ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠹ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via NPM�[?25l�[2K�[1G⠸ Hand picking DIRTY dependencies and devDependencies and devDsiDependencies via 

Feature: Range manipulation

Not sure if this should land into handpick, but there is an experimental feature branch to manipulate the range of dependencies.

handpick-range

Please up or downvote.

Idea: support multiple files

In a monorepo, it might be nice to be able to run one handpick command against multiple package.json files. This might be done by allowing file to be an array.

Just an idea. It's also possible to just run handpick multiple times, it's just a bit more cumbersome.

Monorepo/Yarn Workspaces Compatibility

Does handpick support monorepos? I've attempted to use it within a monorepo package, but I receive the following error:

TypeError: Cannot convert undefined or null to object

Specifically, I'm using the latest version of Yarn.

Add `engines` to the project

It looks like this project is using fs.promises, which was added in Node 10. Might be worth specifying that in the engines for the project. I'm stuck on version 8, so I can't use this, unfortunately. :( It's good to get an explanation as to why, rather than hitting a runtime error when I try to use it. TypeError: Cannot read property 'readFile' of undefined.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.