hep-fcc / fcc-edm Goto Github PK

View Code? Open in Web Editor NEW

3.0 3.0 22.0 649 KB

FCC Event Data Model

C++ 52.53% Shell 0.99% CMake 46.48%

fcc-edm's People

Contributors

Stargazers

Watchers

fcc-edm's Issues

Does not compile on Mac

I am trying to install podio, fcc-edm and fcc-physics on Mac. For each of these I have taken the master from Github and followed the README instructions.

Podio installs fine and tests run as expected.

fcc-edm fails to compile with two items like this.

[ 85%] Building CXX object utilities/CMakeFiles/utilities.dir/DummyGenerator.cc.o
/Users/alice/fccwork0.8/fcc-edm/utilities/DummyGenerator.cc:34:50: error: expected
'(' for function-style cast or type construction
writer.registerForWritefcc::ParticleCollection("GenParticle");
~~~~~~~~~~~~~~~~~~~~~~~^

TrajectoryPoints?

Hi everybody,

In papas we have a data structure called path that contains trajectory parameters and points (reference points on the trajectory). We're talking about a purely geometrical object, this is not a track.

The number of points is arbitrary but limited to ~10, and the points are indexed by a name (e.g. vertex, ecal_entrance, ..). We would like to store such objects in the FCC EDM.

We thought about the following.
What do you think? wouldn't a fixed size array of points be more adequate in fcc::TrajectoryPoints?
Do we have such a thing?
Indeed, we think it is better to have concrete storage of the points within fcc::TrajectoryPoints rather than in a separate collection.

fcc::Helix:
   # here helix parameters
  OneToOneRelations:
  - fcc::TrajectoryPoints points

fcc::StraightLine:
   # here straightline parameters
  OneToOneRelations:
  - fcc::TrajectoryPoints points

fcc::TrajectoryPoints: 
  OneToManyRelations:
  - fcc::Point points

Cheers,

Colin, @alicerobson

Issues in the local installation of the standalone packages

Dear All, I have trying to do the local installation of the FCCSW following the tutorial in http://fccsw.web.cern.ch/fccsw/tutorials/ . I installed successfully PODIO and EDM packages, however, after going through the fcc-physics packge installation, there are two missing header files, the
JetParticleAssociationCollection.h
JetUtils.h
See snapshot.

These files are in the cbernet branch of the fcc-edm, so I would like to recommend a fixing of this issue for the installation of the software locally.
Please let me know how to fix this. I am working on my thesis in Cuba, so I need the local installation, because my connection is very slow.

Add RDataFrame tests when ROOT-6.16 is available

Add commented out tests introduced on #63

fix tracking edm: missing information

Some data members are obviously missing in TrackState (e.g. a reference point, or direction information), making this part of the EDM unusable.

As a first step, we would like to propose a fast fix that consists in adding these data members.

Afterwards, we can always decide to e.g. change the parametrization.

This version of the EDM will accomodate tracks that change momentum within tracker layers in a constant magnetic field. We will probably need to discuss how to deal with varying magnetic fields later on.

More information:

LCIO track: http://lcio.desy.de/v02-07/doc/doxygen_api/html/classEVENT_1_1Track.html
note about LCIO track parameters: http://www-flc.desy.de/lcnotes/notes/LC-DET-2006-004.pdf
our track edm:

fcc-edm/edm.yaml

Line 194 in cbe4b91

fcc::TrackState:

@alicerobson, Colin

Support for sub-jets

Need some support to save sub-jet structures that go beyond float values (i.e. actual sub-jets). Something along the lines of

  fcc::XYZJet :
    OneToManyRelations :
     - fcc::Jet subjets // Result of the tagging algorithm
    OneToOneRelations :
     - fcc::Jet jet // Reference to the jet

fcc-edm master not compatible with podio master (operator<< conflict)

Hello, I've been trying to compile the master version of podio (664b301775979) with the latest version of fcc-edm (22b5abc) on ubuntu 16.04 with gcc version 5.4.0.

Podio compiles and works fine, but the fcc-edm compilation fails with the error messages shown below (*).

The problem is that the ostream operators that are now added by podio to the components are conflicting with the ones in https://github.com/HEP-FCC/fcc-edm/blob/master/utilities/ParticleUtils.h.
And indeed, if I remove the operators from ParticleUtils, fcc-edm compiles and works.

That sounds like a valid complaint from the compiler, and I don't understand how it could work at all at some point. Would anybody have a suggestion to make it work? I'd like to avoid removing the operators in ParticleUtils.

Cheers!

Colin

(*)

/home/cbernet/FCC/fcc-edm/utilities/ParticleUtils.cc: In function ‘std::ostream& operator<<(std::ostream&, const fcc::Particle&)’:
/home/cbernet/FCC/fcc-edm/utilities/ParticleUtils.cc:105:29: error: call of overloaded ‘operator<<(std::ostream&, const fcc::BareParticle&)’ is ambiguous
   operator<<(out, ptc.core());
                             ^
/home/cbernet/FCC/fcc-edm/utilities/ParticleUtils.cc:91:15: note: candidate: std::ostream& operator<<(std::ostream&, const fcc::BareParticle&)
 std::ostream& operator<<(std::ostream& out, const fcc::BareParticle& ptc) {
               ^
/home/cbernet/FCC/fcc-edm/utilities/ParticleUtils.cc:103:15: note: candidate: std::ostream& operator<<(std::ostream&, const fcc::Particle&)
 std::ostream& operator<<(std::ostream& out, const fcc::Particle& ptc) {
               ^
In file included from /home/cbernet/FCC/fcc-edm/utilities/ParticleUtils.cc:2:0:
/home/cbernet/FCC/fcc-edm/utilities/ParticleUtils.h:50:15: note: candidate: std::ostream& operator<<(std::ostream&, const fcc::MCParticle&)
 std::ostream& operator<<(std::ostream& out, const fcc::MCParticle& ptc);
               ^
In file included from /home/cbernet/FCC/fcc-edm/utilities/ParticleUtils.cc:10:0:
/home/cbernet/FCC/fcc-edm/datamodel/datamodel/MCParticle.h:136:15: note: candidate: std::ostream& fcc::operator<<(std::ostream&, const fcc::ConstMCParticle&)
 std::ostream& operator<<( std::ostream& o,const ConstMCParticle& value );
               ^
In file included from /home/cbernet/FCC/fcc-edm/utilities/ParticleUtils.cc:9:0:
/home/cbernet/FCC/fcc-edm/datamodel/datamodel/Particle.h:137:15: note: candidate: std::ostream& fcc::operator<<(std::ostream&, const fcc::ConstParticle&)
 std::ostream& operator<<( std::ostream& o,const ConstParticle& value );
               ^
In file included from /home/cbernet/FCC/fcc-edm/datamodel/datamodel/Particle.h:3:0,
                 from /home/cbernet/FCC/fcc-edm/utilities/ParticleUtils.cc:9:
/home/cbernet/FCC/fcc-edm/datamodel/datamodel/BareParticle.h:22:22: note: candidate: std::ostream& fcc::operator<<(std::ostream&, const fcc::BareParticle&)
 inline std::ostream& operator<<( std::ostream& o,const fcc::BareParticle& value ){ 
                      ^
/home/cbernet/FCC/fcc-edm/utilities/ParticleUtils.cc: In function ‘std::ostream& operator<<(std::ostream&, const fcc::MCParticle&)’:
/home/cbernet/FCC/fcc-edm/utilities/ParticleUtils.cc:112:29: error: call of overloaded ‘operator<<(std::ostream&, const fcc::BareParticle&)’ is ambiguous
   operator<<(out, ptc.core());
                             ^
/home/cbernet/FCC/fcc-edm/utilities/ParticleUtils.cc:91:15: note: candidate: std::ostream& operator<<(std::ostream&, const fcc::BareParticle&)
 std::ostream& operator<<(std::ostream& out, const fcc::BareParticle& ptc) {
               ^
/home/cbernet/FCC/fcc-edm/utilities/ParticleUtils.cc:103:15: note: candidate: std::ostream& operator<<(std::ostream&, const fcc::Particle&)
 std::ostream& operator<<(std::ostream& out, const fcc::Particle& ptc) {
               ^
/home/cbernet/FCC/fcc-edm/utilities/ParticleUtils.cc:109:15: note: candidate: std::ostream& operator<<(std::ostream&, const fcc::MCParticle&)
 std::ostream& operator<<(std::ostream& out, const fcc::MCParticle& ptc) {
               ^
In file included from /home/cbernet/FCC/fcc-edm/utilities/ParticleUtils.cc:10:0:
/home/cbernet/FCC/fcc-edm/datamodel/datamodel/MCParticle.h:136:15: note: candidate: std::ostream& fcc::operator<<(std::ostream&, const fcc::ConstMCParticle&)
 std::ostream& operator<<( std::ostream& o,const ConstMCParticle& value );
               ^
In file included from /home/cbernet/FCC/fcc-edm/utilities/ParticleUtils.cc:9:0:
/home/cbernet/FCC/fcc-edm/datamodel/datamodel/Particle.h:137:15: note: candidate: std::ostream& fcc::operator<<(std::ostream&, const fcc::ConstParticle&)
 std::ostream& operator<<( std::ostream& o,const ConstParticle& value );
               ^
In file included from /home/cbernet/FCC/fcc-edm/datamodel/datamodel/Particle.h:3:0,
                 from /home/cbernet/FCC/fcc-edm/utilities/ParticleUtils.cc:9:
/home/cbernet/FCC/fcc-edm/datamodel/datamodel/BareParticle.h:22:22: note: candidate: std::ostream& fcc::operator<<(std::ostream&, const fcc::BareParticle&)
 inline std::ostream& operator<<( std::ostream& o,const fcc::BareParticle& value ){ 
                      ^
utilities/CMakeFiles/utilities.dir/build.make:134: recipe for target 'utilities/CMakeFiles/utilities.dir/ParticleUtils.cc.o' failed
make[2]: *** [utilities/CMakeFiles/utilities.dir/ParticleUtils.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
CMakeFiles/Makefile2:1115: recipe for target 'utilities/CMakeFiles/utilities.dir/all' failed
make[1]: *** [utilities/CMakeFiles/utilities.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 86%] Built target datamodel-dictgen

Particle Vertex information duplicated

MCParticles both have the reference to the start and end vertex, as well as the BareParticle member https://github.com/HEP-FCC/fcc-edm/blob/master/edm.yaml#L39. It's not clear to me if the last one is needed for the reconstructed Particle or just as a convenience, or not at all.

One to many relation jet->jets (for jet reclustering)

Hello,

following the discussion we had in the FCCSW technical meeting 12/07/2017, I open an issue to follow up on the implementation of some kind of relations to support one to many relation from a jet to jets. In this context the jet is a large R-jet and the jets are small R jets from re-clustering of the large R-jet clusters. This is particularly useful for analyses heavily using sub-structure in very boosted environment.

Cheers,
Clement

@alicerobson did you also get this issue with v0.5?

Cheers,

Colin

hep-fcc / fcc-edm Goto Github PK

fcc-edm's People

Contributors

Stargazers

Watchers

Forkers

fcc-edm's Issues

Recommend Projects

Recommend Topics

Recommend Org

Jobs