heroku / heroku-connect-plugin Goto Github PK

There's lots of useful queries for exploring the trigger log table that we seem to provide to customers regularly. If we could capture those in CLI commands that could be really useful.

https://devcenter.heroku.com/articles/cli-style-guide#dependency-guidelines

Other CLI commands offer a --json option to dump API output directly to the console, where it can be consumed by tools like jq for more advanced scripting. We should do that at least with connect:info, and other commands as appropriate.

Heroku CLI v6 plugins use a very different code format for defining commands and command options. We should upgrade to this structure as well, to start taking advantage of newer features.

In particular, command flags can now be complicated pieces of functionality that can intelligently choose defaults, interactively prompt for options and provide custom objects to the rest of the function. The app flag is a good example of this, and can serve as a template for how we can reimplement our resource flag, and perhaps contribute it back to the core codebase once we have a good implementation.

Currently, connect:info lists very basic information about every Heroku Connect connection on an app. With #67, that'll be harder to make readable, and I'm not convinced this is a good idea anyway. Instead, we should add a separate connect:list command that lists all the connections using a table, something like this:

<customer's defined name> | <our guid> | <resource name>

It would be great if there was a way to pass a flag to connect:info to get the rest of the information that comes with deep=true. This would be especially handy for the case of having to use sudo to get at customer info like row counts without having to fight with API tokens and curl.

maybe a --region so we can support the all the new regions

Hi, I'm currently using your plugin and it is very useful! :)
but when I try to use db-set command I always get an error before trying to set the database.

However, I could do it through the endpoint using directly curl.

It seems to me that the problem is on this method fetchKeys and maybe the error was introduced when doing this change on the db-set.js file but I'm not completely sure.

I wanted to let you know about it. Thanks in advance!

just in case someone needs to push a patch, it would be good to add the shared heroku account as a collab: https://www.npmjs.com/~heroku

Hi,

currently when you import a new mapping, there is not way to know if it will actually work or not. The mapping will always be accepted and eventually your connection state will switch to error.

That behavior makes deployments ever so more risky. Therefore I would suggest to add a new command, something like connect:validate FILE to send a file via API and wait for a response if the mapping could be successfully applied based on the connected Salesforce instance.

I am aware that there are certain limitations that can not easily be overcome, due to the Salesforce API.
But the Heroku Connect interface has a fairly good understanding of the Object and fields structure of the salesforce instance. It is also aware of certain constrains and even displays warnings.

I would assume that this information could be made accessible via the API. But I would suggest to keep it simple. Any kind of validation is better then none. This would be our priority list:

1. Objects and Fields exist
2. Required fields are in the mapping
3. Required indexes are added
4. Polling is not available

I hope that helps a bit, we would certainly appreciate such a feature. We could build the plugin part, but you guys need to provide the API.

Best
-Joe

heroku connect:db:set --schema salesforce --db DATABASE_URL --app "$HEROKU_APP_NAME"

produces no stdout or stderr and the connection remains on NEW.

You can reproduce this by simply trying our sample app: https://github.com/Thermondo/django-heroku-connect-sample

Hello,

I'm trying to diagnose the connection as described in here, by running heroku connect:diagnose --verbose, but it returns an error

Diagnosing connection... done

=== Connection: magellan-jets-api
▸    Cannot read property 'length' of undefined

Here is a workaround I received from support heroku connect:mapping:diagnose user

This will likely also require reformatting the results using cli.styledHash, so it's actually readable.

It seems that the current best practice for heroku cli plugins is to use a top level commands and a top-level lib directory that contains the helper utilities for the commands. Currently our commands directory is under lib.

Hi there,

What does connect:sf:auth --login do?

I see that is passes an argument to the API call, but it is not actually documented as part of the API.
https://devcenter.heroku.com/articles/heroku-connect-api#step-6-authenticate-the-connection-to-your-salesforce-org

Best!
-Joe