Comments (12)
Hey @dcmoeller, thanks for the detailed report! I'll investigate and update this issue with my findings.
from heroku-gradle-plugin.
What was your working directory when you encountered the overly long file paths in scenario three? Can you try again while your working directory is the project directory, if not already the case?
from heroku-gradle-plugin.
@Malax: All commands shown are issued in project's directory, the one containing build.gradle
.
from heroku-gradle-plugin.
I was able to reproduce this when running with my local Gradle installation (i.e. gradle build deployHeroku
). It works correctly when using the Gradle wrapper from the project (./gradlew build deployHeroku
). I assume the demon does something that trips off our path resolution code.
Try running the deploy with gradlew
as a workaround for now. I'll see that we have a fix for this next week.
from heroku-gradle-plugin.
Interesting! I've not tried local Gradle installation, I've always used project's Gradle Wrapper ./gradlew ...
.
from heroku-gradle-plugin.
I'm using Gradle version 6.5.1. Here it show that both invocations gradle deployHeroku
as well as ./gradlew deployHeroku
behave the same!
from heroku-gradle-plugin.
Some more output from my invocations, maybe this helps:
$ ./gradlew deployHeroku
Executed by Gradle 6.5.1
> Task :deployHeroku
-----> Packaging application...
- app: [APPLICATION]
- including: /home/[USER]/.gradle/daemon/6.5.1/build/libs/[APPLICATION].jar
-----> Creating build...
- file: build/heroku/build.tgz
- size: 13MB
-----> Uploading build...
- success
-----> Deploying...
remote:
remote: -----> heroku-gradle app detected
remote: -----> Installing JDK 14... done
remote: -----> Discovering process types
remote: Procfile declares types -> web
remote:
remote: -----> Compressing...
remote: Done: 79.3M
remote: -----> Launching...
[...]
Exactly the same output and outcome if using gradle deployHeroku
.
from heroku-gradle-plugin.
@dcmoeller I started work on a new major version for this plugin which leverages an updated heroku-deploy
version that does not show this bug. You can track progress in my draft PR #22. I'm hopeful we can get this out of the door this or at least next week.
from heroku-gradle-plugin.
Looking forward 😃
By the way, fixed issue myself by modifying one line from my original post containing includes:
like this (beware of using absolute path here by using Gradle's buildDir
path variable):
includes = ["${buildDir}/libs/[APPLICATION].jar"]
With this you can also modify processTypes(web ...)
to the following expected version:
web: "java \$JAVA_OPTS -jar ./build/libs/[APPLICATION].jar" as String
This works.
from heroku-gradle-plugin.
Hey @dcmoeller, 2.0.0
has been released last friday. Can you confirm it resolves your issue? :)
from heroku-gradle-plugin.
Confirmed: My "Third szenario" works now 👍
To import new version I have to switch the following clause in build.gradle
:
//classpath 'gradle.plugin.com.heroku.sdk:heroku-gradle:1+'
classpath 'gradle.plugin.com.heroku.sdk.heroku-gradle:heroku-gradle:2+'
from heroku-gradle-plugin.
Thanks for confirming and the initial report! 👍
from heroku-gradle-plugin.
Related Issues (16)
- heroku.appName by System property HOT 4
- Can't Find 'FileUtils' in HerokuPluginExtension HOT 1
- Heroku pipelines integration HOT 7
- Unable to deploy executable jar
- CI not working HOT 2
- New release HOT 2
- Warning: You are running on a deprecated stack. HOT 1
- Cannot deploy an app with Gitlab CI HOT 3
- PostgreSQL compatibility? HOT 1
- Where's heroku login? HOT 2
- Read the app name from app.json HOT 4
- Improve README documentation HOT 3
- deployHeroku task should depend on stage task HOT 1
- Bump version of com.heroku.sdk:heroku-deploy dependency to 3.0.4 HOT 2
- Heroku login HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from heroku-gradle-plugin.