Comments (7)
Alternatively, you can use this API to create a review app where you provide us with the correct branch name and commit hash in the "source_blob:version"
When you prepare your source blob tar.gz
, you can put in your fat JAR that you built on CircleCI together with a Procfile
. This should get you your desired result of having only one build setup on CircleCI and review apps on Heroku that are linked in GitHub PRs.
from heroku-gradle-plugin.
@nedtwigg yes and no. The app you deploy to with deployHeroku
can be an app in your pipeline, and you can promote it through the pipeline like any other app. But Review apps will only work with code pulled from Github.
To mimic review apps, you could deploy to a temporary app from CI. That's the only workaround I can think of.
I'd be happy to try and help get the Gradle build working on Heroku with git push
too. Please open a ticket and we can take a look.
from heroku-gradle-plugin.
Roger. So yes for staging apps, no for review apps.
Thanks @jkutner! I've got an open ticket here: https://help.heroku.com/sharing/66569475-ed98-40f2-a17e-662286b3af44
from heroku-gradle-plugin.
Thanks a lot for the great support inside that ticket, @jkutner. For anybody else wishing to deploy small fatjars using the standard heroku build (not the gradle plugin), here was the trick:
task stage {
dependsOn 'TASK_THAT_MAKES_FATJAR'
doLast {
delete fileTree(dir: '.', exclude: [
'Procfile', 'app.json',
'system.properties', '.profile.d/**', '.jdk/**', '.heroku/**',
'YOURFATJAR')
}
}
from heroku-gradle-plugin.
Is it still true that it is not possible to create review apps programmatically? I noticed that there was a new review app rollout, didn't know if perhaps the new system allows review apps built outside of Heroku. I get a lot of joy out of these two features:
- every PR has a link to CircleCI results
- every PR has a link to a Heroku preview app
I get no joy out of supporting two different build environments, and I definitely prefer a dedicated CI tool.
from heroku-gradle-plugin.
Hey @nedtwigg! With the new review apps, it's now possible to couple any existing app to the "review"
stage: https://devcenter.heroku.com/articles/platform-api-reference#pipeline-coupling-create
However, the app will not show up in a GitHub pull-request. If I understood you correctly, this is something you want to achieve. You might be able to do this by using the GitHub API to comment on the associated pull request.
Let me know if you have further questions. :)
from heroku-gradle-plugin.
Thanks very much for the links!
from heroku-gradle-plugin.
Related Issues (16)
- heroku.appName by System property HOT 4
- CI not working HOT 2
- New release HOT 2
- Warning: You are running on a deprecated stack. HOT 1
- Cannot deploy an app with Gitlab CI HOT 3
- PostgreSQL compatibility? HOT 1
- Artifact is deployed to Heroku platform under its full filesystem path in Gradle daemon's directory HOT 12
- Where's heroku login? HOT 2
- Read the app name from app.json HOT 4
- Improve README documentation HOT 3
- deployHeroku task should depend on stage task HOT 1
- Can't Find 'FileUtils' in HerokuPluginExtension HOT 1
- Bump version of com.heroku.sdk:heroku-deploy dependency to 3.0.4 HOT 2
- Heroku login HOT 3
- Unable to deploy executable jar
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from heroku-gradle-plugin.