herredro / dashboard_react Goto Github PK

JavaScript

• DashNav indication for selection (with var classes?)
• Possibility of showing multiple Dashes

Data

• Integration of VanillaJS in React Components
  • Maps API
  • Lyrics API
    • Forms with Hooks (https://reactgo.com/react-hooks-forms/)

Style

• Nicer Buttons/Whatever to navigate
• On/Off Switches for modules

1. Unclear Code features

• What is the var classes for?
  • So far, there is no className-prop passed to MapContainer to push in list (-> undefined)
  • Features being enabled by this:
    • Button coloring depending on state (right, @olivierbrcknr?)
    • A kind of history function to jump back.
    • ...

• where is it called? I feel like this is redundant, since I don't see any code calling this. There are only calls to setFocus directly (see below).

• callBack - when is this event triggered and where?
  I only see setFocus being called directly (in the callback function of DashNav). Should switchFocus be called instead?

2. Unclear React features

• @olivierbrcknr Is this "the way to do it"? I.e.: is it generaly better style to call a local function first, that then calls the prop function?

  I would have done "onClick={props.clickHandler}"
  (@olivierbrcknr, would this ^ be called a callback or just a function that was passed as a prop?)