The nerdshow from hgoebl

nerdshow's People

Contributors

Stargazers

Watchers

nerdshow's Issues

Catch SIGTERM signal to gracefully terminate

While dockerizing the app, I've found that it ignores SIGTERM signals from both CTRL+C and docker stop commands (it just gets killed after 10 seconds in the later case).
Trapping SIGTERM signal to terminate gracefully would prevent this annoyance.
Thank you for this useful app.

Socket.IO compatibility

I just wanted to try nerdshow. Installed it via npm, cloned the github example and started with nerdshow folder/in/which/the/presentation/is/ --debug and got this error message:

Warning: express.createServer() is deprecated, express
applications no longer inherit from http.Server,
please use:

  var express = require("express");
  var app = express();

Socket.IO's `listen()` method expects an `http.Server` instance
as its first parameter. Are you migrating from Express 2.x to 3.x?
If so, check out the "Socket.IO compatibility" section at:
https://github.com/visionmedia/express/wiki/Migrating-from-2.x-to-3.x
   info  - socket.io started

/usr/local/share/npm/lib/node_modules/nerdshow/lib/server/server.js:85
        app.address().port, app.settings.env);
            ^
TypeError: Object function app(req, res){ app.handle(req, res); } has no method 'address'
    at Object.<anonymous> (/usr/local/share/npm/lib/node_modules/nerdshow/lib/server/server.js:85:13)
    at Module._compile (module.js:449:26)
    at Object.Module._extensions..js (module.js:467:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Module.require (module.js:362:17)
    at require (module.js:378:17)
    at Object.<anonymous> (/usr/local/share/npm/lib/node_modules/nerdshow/bin/nerdshow-run:3:1)
    at Module._compile (module.js:449:26)
    at Object.Module._extensions..js (module.js:467:10)

Looks like a compabitlity/dependency issue.

Recommend Projects