hhvm / hhvm-third-party Goto Github PK

The commit e0fcd65 to roll sqlite3 forward to release from 3.7.15.2 to 3.8.4.3 breaks the execution on ubuntu 13.10. There's an early runtime fatal error regarding $HOME/.hhvm.hhbc not being able to accept a COMMIT from sqlite3. That's true even after removing the file and rebooting.

I rolled back the change, rebuilt, and the problem goes away.

See facebook/hhvm#2194 which seems related, also saying there were issues with sqlite3 3.8

This is more involved, as I believe it requires adding a dependency on Fizz, which in turn makes libsodium required. HHVM itself currently has libsodium as an optional dependency. The next update will require:

• adding fizz
• checking if supported distributions have new enough sodium versions for fizz
• if the version is new enough for fizz, but not ext_sodium, conditionally disabling functions in libsodium
• if there is no libsodium, or it's too old for fizz, make sure that FB can distribute binaries including it
• if there is no libsodium or it's too old for fizz and we can distribute, add to the open source build system, and test on all supported distributions
• if we can't distribute binaries with fizz/sodium, we need to make those dependencies optional

The oldest distributions we currently support are Debian 8 (Jessie) and Ubuntu 14.04 (Trusty). All builds use G++5 or above.

a 'make clean' in libmbfl/mbfl/ removes eaw_table.h. There is no rule to make this file, so it is not possible to 'make' after running 'make clean'.

Thrift currently doesn't build on OS X using its default compiler environment (clang and libc++). This is due to the Thrift copy in hhvm-third-party still depending on C++11 TR1 being present. Upstream Thrift has fixed this and compiles with either TR1 or actual C++11 (depending on which is present).

The following diff allows me to compile HHVM:

diff --git a/thrift/lib/cpp/async/TEventBase.h b/thrift/lib/cpp/async/TEventBase.h
index d96b708..b98e519 100644
--- a/thrift/lib/cpp/async/TEventBase.h
+++ b/thrift/lib/cpp/async/TEventBase.h
@@ -22,14 +22,14 @@
 #include <utility>
 #include <boost/intrusive/list.hpp>
 #include <boost/utility.hpp>
-#include <tr1/functional>
+#include <functional>
 #include <event.h>  // libevent
 #include <errno.h>
 #include <math.h>

 namespace apache { namespace thrift { namespace async {

-typedef std::tr1::function<void()> Cob;
+typedef std::function<void()> Cob;
 template <typename MessageT>
 class TNotificationQueue;

@@ -407,7 +407,7 @@ class TEventBase : private boost::noncopyable, public TimeoutManager {

   // --------- libevent callbacks (not for client use) ------------

-  static void runTr1FunctionPtr(std::tr1::function<void()>* fn);
+  static void runTr1FunctionPtr(std::function<void()>* fn);

   // small object used as a callback arg with enough info to execute the
   // appropriate client-provided Cob
diff --git a/thrift/lib/cpp/concurrency/ThreadManager.h b/thrift/lib/cpp/concurrency/ThreadManager.h
index 92899cc..ae6fad7 100644
--- a/thrift/lib/cpp/concurrency/ThreadManager.h
+++ b/thrift/lib/cpp/concurrency/ThreadManager.h
@@ -21,7 +21,7 @@
 #define HPHP_THRIFT_CONCURRENCY_THREADMANAGER_H 1

 #include <memory>
-#include <tr1/functional>
+#include <functional>
 #include <sys/types.h>
 #include <array>
 #include <unistd.h>
@@ -55,8 +55,8 @@ class ThreadManager {

  public:
   class Task;
-  typedef std::tr1::function<void(std::shared_ptr<Runnable>)> ExpireCallback;
-  typedef std::tr1::function<void()> InitCallback;
+  typedef std::function<void(std::shared_ptr<Runnable>)> ExpireCallback;
+  typedef std::function<void()> InitCallback;

   virtual ~ThreadManager() {}

diff --git a/thrift/lib/cpp/config.h b/thrift/lib/cpp/config.h
index 481c80e..19d942a 100644
--- a/thrift/lib/cpp/config.h
+++ b/thrift/lib/cpp/config.h
@@ -263,7 +263,7 @@
 #define STDC_HEADERS 1

 /* Define to 1 if strerror_r returns char *. */
-#define STRERROR_R_CHAR_P 1
+//#define STRERROR_R_CHAR_P 1

 /* Define to 1 if you can safely include both <sys/time.h> and <time.h>. */
 #define TIME_WITH_SYS_TIME 1

I see 3 options to fix this: either the bundled Thrift copy gets updated to a newer version, the code gets patched or Thrift doesn't get bundled anymore as an in-tree copy.

Commit 9f6ae51 switched from webscalesql-5.6 to mysql-5.6.git. The latter does not give a clean
git status after a build. Several non-ignored files are generated, including one which exists as a checked in file and therefore diffs. I tried submitting a fix to mysql-5.6 but it was rejected in favor of fixing upstream. I don't have a contributor agreement in place with Oracle.

Can't use awk because of strtonum, so we shouldn't have awk anywhere.

d53dc7a
1d387ce

Since 486597c, compilation fails for me with thrift/lib/cpp/async/TAsyncTransport.h not found. The files CMake generates all lack the new src/ path component.

Hello,
Sqlite3 library seems not to support FTS4 unicode61 tokenizer by default. Is there a way to build HHVM version with support of this feature?

the upstream version of this package is basically dead.

Maybe liftafdt should be renamed libfbafdt (or something else) and then put in a separate repository.

libmbfl seems pretty slow to respond to patches, so it'd be nice to have a real place to submit patches to. They could easily grab the patches back later, should they become more active in the future.

Are these curl patches still used by anybody internally?

https://github.com/hhvm/hhvm-third-party/blob/master/libcurl-7.22.1.fb-changes.diff
https://github.com/hhvm/hhvm-third-party/blob/master/libcurl.fb-changes.diff

double-conversion is now on github officially (https://github.com/floitsch/double-conversion) , so we can include it as a submodule.

It also now seems to have enhanced support for building on windows, both with cygwin and as normal.

NOTE: there are some build changes though. A cursory glance shows me that the source directory has moved into a sub directory and the various CMake files have been expanded.

HHVM 3.24 requires the reference arguments to be marked at the call site, making the TravisCI build for third-party to fail (https://travis-ci.org/hhvm/hhvm-third-party/builds/339611891?utm_source=github_status&utm_medium=notification).

The "sort" call in util/make-notices.hh:88 needs the argument to be marked as a reference at the call site.

libafdt is now on github, so we can use it as a submodule now: https://github.com/facebook/libafdt