Crash when creating journal from zone with allow_update=true about hickory-dns

[bluejekyll]

I wonder if there's another bug here. It looks like the journal filename is wrong, is it possible that the new journal is empty?

How did you produce this problem?

[apexo]

I just used the example config src/config/test/example.toml with the following extra zone:

[[zones]]
zone = "example.com"
zone_type = "Master"
file = "example.com.zone"
allow_update = true

[apexo]

Before the crash, the journal file does not exist. After the crash, it exists with size 0.

[bluejekyll]

Ok, mind fixing another two lines in this? on:

https://github.com/bluejekyll/trust-dns/blob/master/src/named.rs#L94

the set_extension(".jrnl") should be set_extension("jrnl")
and similarly set_extension(".key") should be set_extension("key")

I don't know how I missed that, but I know that I don't have startup tests on the binary. I need to go back and add those. Anyway, if you could make those other changes too that would be awesome. Otherwise I'll do that later.

[apexo]

Will do.

[bluejekyll]

Thanks for the changes!