Panic when using nested setTimeout and when calling clearTimeout() about quickjs_es_runtime

[andrieshiemstra]

ah, the problem was again in the EventLoop in utils, the deadline for the next run was calculated before actually running the timeout jobs, so the new one was not yet present in the list and thus eventloop fell back to the 10 sec default.. fixed in utils 0.1.3

[andrieshiemstra]

Setting max_stack_size to u64::MAX works, but it's better not to set to a MAX value as I would like to prevent too many nested function calls.

e.g.

The above code causes a crash with fatal runtime error: stack overflow when max_stack_size is set with u64::MAX. Without setting any max_stack_size, it returns a proper error InternalError: stack overflow at at a (basics.es:3)

agreed, but I need a new version of quickjs to fix this (theduke/quickjs-rs#116)

[andrieshiemstra]

Nice catch! thanks!

The problem was actually in the EventLoop in utils, i published a 0.1.2 version which fixes this, if you are using a quickjs_es_runtime which depends on utils = "0.1" it should update to the fixed version if you do a clean build.

Kind regards

[SreeniIO]

use futures::executor::block_on;
use hirofa_utils::js_utils::Script;
use log::LevelFilter;
use quickjs_runtime::esruntime::EsRuntime;
use quickjs_runtime::esruntimebuilder::EsRuntimeBuilder;
use std::sync::Arc;

async fn test(rt: Arc<EsRuntime>) {
    let res = rt
        .eval(Script::new(
            "basics.es",
            r#"
            new Promise((resolve) => {
                setTimeout(() => {
                    console.log('in timeout 1');
                    setTimeout(() => {
                        console.log('in timeout 2'); // this should get printed in 2 seconds
                        resolve(true);
                    }, 1000); // > 10s works as expected, but < 10s always takes 10 seconds
                }, 1000);
            });
        "#,
        ))
        .await
        .ok()
        .unwrap();

    let fut = res.get_promise_result();
    let val = fut.await;
    println!("{:?}", val);
}

fn main() {
    simple_logging::log_to_stderr(LevelFilter::Info);
    let rt = EsRuntimeBuilder::new().build();
    block_on(test(rt));
}

In the above sample code, the 2nd console.log is getting printed after 10 seconds irrespective of the timeout value. But if the timeout value is more than 10 seconds, then it's waiting as expected.

[andrieshiemstra]

hmm, that also is an issue with the eventloop not triggering properly, i'll look into it asap

[SreeniIO]

There seems to be an issue with setInterval from the below code, you could see it prints setInterval func failed: InternalError: stack overflow at every second whenever the setInterval is triggered...

use futures::executor::block_on;
use hirofa_utils::js_utils::Script;
use log::LevelFilter;
use quickjs_runtime::esruntime::EsRuntime;
use quickjs_runtime::esruntimebuilder::EsRuntimeBuilder;
use std::sync::Arc;

async fn test(rt: Arc<EsRuntime>) {
    let res = rt
        .eval(Script::new(
            "basics.es",
            r#"
            setInterval(() => {
                console.log('in setInterval 1');
            }, 1000);
            new Promise((resolve) => {
                setTimeout(() => {
                        resolve(true);
                }, 10000);
            });
        "#,
        ))
        .await
        .ok()
        .unwrap();

    let fut = res.get_promise_result();
    let val = fut.await;
    println!("{:?}", val);
}

fn main() {
    simple_logging::log_to_stderr(LevelFilter::Info);
    let rt = EsRuntimeBuilder::new().build();
    block_on(test(rt));
}

[andrieshiemstra]

There seems to be an issue with setInterval from the below code, you could see it prints setInterval func failed: InternalError: stack overflow at every second whenever the setInterval is triggered...

I am unable to reproduce this, it works as expected for me but it might be an issue with the stack overflow check in quickjs.

Could you start the runtime with adding this to the builder?

let rt = EsRuntimeBuilder::new().max_stack_size(u64::MAX).build();

The quickjs stack check has a tendancy to overflow (from a negative number to a large positive number) causing it to think the stack is realy large.

I think thats why they added JS_UpdateStackTop() (see https://bellard.org/quickjs/Changelog) but i have not implemented that yet (see #50)

[SreeniIO]

Setting max_stack_size to u64::MAX works, but it's better not to set to a MAX value as I would like to prevent too many nested function calls.

e.g.

function a(counter) {
    console.log(counter);
    b(++counter);
}
function b(counter) {
    a(++counter);
}
a(1);

The above code causes a crash with fatal runtime error: stack overflow when max_stack_size is set with u64::MAX. Without setting any max_stack_size, it returns a proper error InternalError: stack overflow at at a (basics.es:3)