hirosassa / zerodriver Goto Github PK

https://goreportcard.com/report/github.com/hirosassa/zerodriver

I think it's common pattern that logging error and sending events to monitoring service like Sentry, when an error happens.

so it's nice if this logger support sentry, like https://github.com/archdx/zerolog-sentry

some requirements image:

• can enable/disable sentry sending per each .Msg() call
• automatically set sentry event's error level according to logger's error level
• works with sentry's additional package like https://docs.sentry.io/platforms/go/guides/http/ (automatically set http request info to sentry events)
• automatically set logger's label data to sentry events

The *.err(err Error) API from zerodriver is not behaving like the one from zerolog.

The execution of the following command

package main

import (
	"github.com/hirosassa/zerodriver"
	"github.com/rs/zerolog/log"
)

func main() {
	driverLog := *zerodriver.NewProductionLogger()
	log.Logger = *driverLog.Logger
	driverLog.Err(nil).Msg("error")
	log.Err(nil).Msg("error")
}

is

{"severity":"ERROR","time":"2022-12-02T16:16:39.642678263+01:00","message":"error"}
{"severity":"INFO","time":"2022-12-02T16:16:39.642704011+01:00","message":"error"}

This is the result of the usage of the wrong API in the abstraction layer at:

e := l.Logger.Err(err)

https://github.com/blendle/zapdriver#using-error-reporting

Currently, Labels returns *zerolog.Event. So, we can't call Labels command more than once.
I want to do it as follows.
Do you think about this?

// prepare common label
commonLogger := logger.Info().Labels(zerodriver.Label("label", "common"))

commonLogger.Labels("phase", "1").Msg("hoge")
commonLogger.Labels("phase", "2").Msg("fuga")

https://github.com/blendle/zapdriver#sourcelocation