Comments (11)
Thanks for the appreciation! I'm glad you find it useful.
About adding em support, yeah, why not. I didn't think of it because I personally don't use them that much, but the Gridlover app uses them and since this is kind of a "Sass port" of their app, it would be consistent to add support to ems.
What I think would be the best approach, would be to let the users decide which unit they'd like to output. For example:
- px
- rem
- px/rem (rems with pixels fallback)
- em
This could be achieved via variables, as it is working right now with the rem support. What do you think?
I could try and give it a try this week. But if you would like to help, don't hesitate!
Thanks!
from sassy-gridlover.
Oh, It maybe a wrong question, I asked how to re-config it for ems ) cause I need flexible config for project and I don't want to change my setup with the GridLover.app. I'll see it later, have no free time now.
from sassy-gridlover.
Hi,
I've been trying to add em support but I haven't been successful due to the relativity of ems. I can't figure out the way to do it...
I've created a branch for testing em support https://github.com/hiulit/Sassy-Gridlover/tree/em-support
from sassy-gridlover.
Yea, first time I tried to replace rem by em and that was the reason to make an issue =) cause output was another size.
I think all calculations have to be in px val, then translate the output into em or any other vals. It gives more flexible config for the future, for example if somebody want to support vh or vw.
from sassy-gridlover.
I've been in contact with the Gridlover app team and we'll try to figure it out.
from sassy-gridlover.
Great, let me know.
from sassy-gridlover.
+1!
from sassy-gridlover.
Quick update. I've been in contact with one of the Gridlover developers but unfortunately neither of us have the time right now to take a deep look into this matter. So any help is extra welcome :)
from sassy-gridlover.
There's a branch for this issue https://github.com/hiulit/Sassy-Gridlover/tree/em-support
from sassy-gridlover.
Good news everyone!
@walmokrani help a lot with this issue #7. I have to take a look at it so I can merge it. But it's looking good :D
from sassy-gridlover.
Hey guys @alekspetrov @cibulka !
I've just released v2.0.0 with em support! Check it out and tell me what you think or if it works for you! ;)
Thanks again to @walmokrani !
from sassy-gridlover.
Related Issues (17)
- something is odd here HOT 4
- Line Heights with Ems HOT 4
- NPM Package? HOT 2
- Create a Stylus port
- Create a Less port
- Rewrite $step3 on sgl-heading mixins ? HOT 7
- Use !default in your variables _config.scss HOT 6
- dart-sass: deprecation warning: !global assignments won't be able to declare new variables HOT 3
- Default export HOT 7
- Error: Invalid null operation: "null times 2.36859" HOT 11
- npm publish HOT 3
- Don't append unit HOT 3
- Use pow() when available
- Consider constant naming conventions HOT 2
- Consider using SassDoc HOT 12
- use less generic functions names HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sassy-gridlover.