Line Heights with Ems about sassy-gridlover

[ChrisSargent]

Also - is there any quick way to tighten up the line heights on some headings? Or should it be overwritten in the SASS?

Chris

[hiulit]

Hi there @ChrisSargent

First of all, I'm glad you like it :)
And yes, you are right. When using em the layout goes slightly off the grid :(

First I thought it was because of the decimal precision. I did a little research on the subject and I found this issue sass/sass#1122.

By default, Sass has a decimal precision of 5 (and it seems that it's not gonna change any time soon) and the Gridlover app uses a decimal precision of 16, so I thought this might be it.

But then I realized that what the Gridlover app actually does is to ceil() the decimals when using em (or at least in some cases, I don't know exactly).
So, instead of outputting 1.2222222222222222em, they output 1.2222222222222223em.
That's what does the trick, I think.

I borrowed some functions from @terkel https://gist.github.com/terkel/4373420 to help with this matter and I think I got it working.

I'll release a new version with these changes and I would really love to hear your feedback!

P.S. Speaking of the debug mode. Maybe I wasn't clear enough or maybe it should be done differently, but right now it must be declared in your _variables.scss or _config.scss or the like in order to work. Basically, it must be declared before the @import "sassy-gridlover".
Do you think it could be implemented in another way? Maybe with a mixin?

P.P.S. I'm afraid there's no easy way to do what you want with the line heights. This project is essentially a 'Sass port' of the Gridlover app and they don't provide this kind of functionality.
You could try playing with the default line-height and scale-factor and see if you get something more to your liking. But apart from that, I think it's best if you just override them yourself.

[hiulit]

Hey @ChrisSargent

I've just released a new version https://github.com/hiulit/Sassy-Gridlover/releases/tag/v3.1.1 with some changes regarding this issue ;)

[ChrisSargent]

Awesome, I'll try to update asap but it'll probably be a day or two.

Chris

On 14 Jul 2016, at 15:48, hiulit [email protected] wrote:

Hey @ChrisSargent

I've just released a new version https://github.com/hiulit/Sassy-Gridlover/releases/tag/v3.1.1 with some changes regarding this issue ;)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.