hmrc / init-service Goto Github PK

The version of assets-frontend that's hard coded here is out of date.

Rather than it being hard coded and having to update it in the service every time one's been created, could it be made dynamic? it could pull the latest version from somewhere at run time.

Just a few suggestions to improve the scaffolding when you create a new service.

When you generate your new microservice using the script it the controller generates is called "MicroserviceHelloWorld". It might be good to use name conventions, e.g. "HelloWorldController" or "${ProjectName}HelloWorldController".

Scaffolding the folder structure (assets, controllers,connectors, services) might also be useful.

Within the controller there is also only 1 method to answer a "get" with hello world. Perhaps expanding this to have scaffolding for all the RESTful api calls would be nice as well.

Finally, is there a way to scaffold an authenticated controller vs a public controller, so that when starting out the auth requirements are baked in with specified Enrollments?

Just a quick question/suggestion on this - is it/can we make it so that it also scaffolds tests for the generated code? It would be fantastically useful to have some template tests as well as the controller, etc.

Upon creating a new service using a template, the project shows minor versions out of date with sbt validate
SBT version is also a minor version behind the supported platform version

The following code supplied a default Nav link which sends users to http://www.google.co.uk/ https://github.com/hmrc/init-service/blob/master/templates/service/app/views/govuk_wrapper.scala.html#L23-L26

We shouldn't supply an off platform Default Home link as there's a risk this might get left in place rather than overridden as intended.

@gavinwye believes that it shouldn't supply any markup by default.

There are 36 mostly blank lines being generated before the doctype declaration includng 3 ')' so ))) is getting rendered before the header in the browser.

When using sbt idea and then opening the project in Idea 2016.1.3 error messages are as shown. Given sbt support in Idea now, should this be removed?

When importing the sbt project within idea it does work ok after configuring the scala sdk to be used in with the project then rebuilding and restarting - otherwise it was not recognizing play libraries, which I suppose is configuration my end since the project files remain unchanged.