GithubHelp home page GithubHelp logo

Comments (11)

retokromer avatar retokromer commented on June 26, 2024 2

Done in #160

from homebrew-ffmpeg.

slhck avatar slhck commented on June 26, 2024

Good suggestion!

I think we still have to wait until ffmpeg 6.0 is out on Homebrew core, because libplacebo there still depends on ffmpeg 5.x. This is the open PR: Homebrew/homebrew-core#124363

from homebrew-ffmpeg.

ahobsonsayers avatar ahobsonsayers commented on June 26, 2024

Interestingly, I was looking at the formula for libplacebo today and I'm actually unsure why ffmpeg is a dependency. Certainly it is not according to the libplacebo readme. I also tried modifying and installing the formula without ffmpeg as a dependency and libplacebo seems to work fine.

I was actually considering opening a PR over there, cos I can only deduct it was included as a dependency by mistake.

from homebrew-ffmpeg.

slhck avatar slhck commented on June 26, 2024

Yeah, you're right β€” thinking about it, it should be the other way around.

from homebrew-ffmpeg.

retokromer avatar retokromer commented on June 26, 2024

Thank you @ahobsonsayers for the suggestion! Unless you open a PR before, possibly I can do it on Friday.

I was actually considering opening a PR over there, cos I can only deduct it was included as a dependency by mistake.

Update: I mean here on this repository. I have noticed your other PR.
Update 2: done.

from homebrew-ffmpeg.

retokromer avatar retokromer commented on June 26, 2024

@ahobsonsayers : I have prepared a PR which should implement your suggestion, but I suggest to wait until your PR on Homebrew is done.

from homebrew-ffmpeg.

ahobsonsayers avatar ahobsonsayers commented on June 26, 2024

@retokromer this is awesome! Thanks! You got on that amazingly quickly ☺️

from homebrew-ffmpeg.

ahobsonsayers avatar ahobsonsayers commented on June 26, 2024

So I have created a PR to try and fix the libplacebo homebrew formula, however I am having problems getting it to work. If I'm honest I am a bit out of my depth as my background is not c++ and I have no experience in its toolchain or homebrews ecosystem for that matter.

Don't suppose anyone has any advice?

from homebrew-ffmpeg.

slhck avatar slhck commented on June 26, 2024

I'm afraid this is also beyond my experience!

from homebrew-ffmpeg.

bbgdzxng1 avatar bbgdzxng1 commented on June 26, 2024

@ahobsonsayers, recent work on libplacebo in Homebrew/homebrew-core#153961 may help - there have been a few changes to libplacebo regarding shaderc/glslang and removing sdl2 as a dependency for plplay. Furthermore, it may be worth revisiting now that FFmpeg 6.1 is out. I'm too stupid to fully understand the implications, but it looks like there has been some housekeeping which may now clear upstream dependencies. Please ignore (or thumbs down) if this comment is irrelevant. Thanks for everyone's efforts in trying to get libplacebo into the homebrew-ffmpeg tap.

from homebrew-ffmpeg.

ahobsonsayers avatar ahobsonsayers commented on June 26, 2024

@bbgdzxng1 thanks for the ping. I had been following the progress of that PR but hadn't noticed it had been merged. I'll see if I can have another look at it this weekend and hopefully create a PR to get it all working!

from homebrew-ffmpeg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.